Repository navigation
Conversation
wpcom_enable_rtc() now returns false before any of the plan, Gutenberg and rollout checks, unless the new wpcom_rtc_rollout_enabled filter returns true. The package already hides the Writing setting, forces the option to 0 and switches the Gutenberg experiment off when a site is not allowed, so nothing else changes. P2 and WP for Teams sites are allowed by the wpcom layer at priority 20 on HTTP polling and are not affected. Related to DOTCOM-18664.
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
rcrdortiz
marked this pull request as ready for review
September 23, 2026 09:05
rcrdortiz
deleted the
dotcom-18664-disable-real-time-collaboration-on-wordpresscom
branch
September 23, 2026 10:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to DOTCOM-18664
Proposed changes
wpcom_enable_rtc()injetpack-mu-wpcomreturnsfalsebefore any of the plan, Gutenberg version and rollout checks, unless the newwpcom_rtc_rollout_enabledfilter returnstrue. The gating is left intact so the rollout can be restored by flipping the filter.rtcpackage already hides the "Enable real-time collaboration" field on Settings > Writing, forceswp_collaboration_enabledto0, and switches thegutenberg-real-time-collaborationexperiment off with it.wp-content/mu-plugins/wpcom-gutenberg-rtc.php) allows them at priority 20 on HTTP polling, which does not usewp.sync.AGENTS.md) records the switched-off state.Why
wp.syncpackage (Sync: Remove exposed wp.sync package WordPress/gutenberg#81999). The PingHub transport in thertcpackage is built againstwp.syncandwp.sync.Y, so once that merges the provider script stops loading and Simple sites silently fall back to HTTP polling.Related product discussion/links
Does this pull request change what data or activity we track or use?
No. The
jetpack_rtc_*events stop firing on WordPress.com sites because the feature is off, but no event definitions change.Testing instructions
On a WordPress.com Simple or Atomic site with a Personal plan or higher, with this branch's
jetpack-mu-wpcomloaded:window.jetpackRTCis undefined in the console.wp.data.select( 'core/editor' )and the network tab show no requests to the PingHub token endpoint (/wp-json/jetpack/v4/rtc/pinghub-token) or the sync storage.cd projects/packages/jetpack-mu-wpcom && vendor/bin/phpunit-select-config phpunit.#.xml.dist --filter Gutenberg_RTC_Test(14 tests pass).