Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: removed

Remove the page descriptions from the dashboard and report pages.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: removed

Remove the date configuration subtitle from the section header.
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ one width and not another. Two things to know if you add a form:

## `formatDateRangeLong( range?, options? )`

Format a date range in explicit, readable form, for prominent surfaces such as
the section header subtitle. Returns `''` when range or dates are missing.
Format a date range in explicit, readable form, for prominent surfaces.
Returns `''` when range or dates are missing.

The shape follows the range's own length, along two independent axes. A window
of a week or less leads each end with its weekday, which is what makes a
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ function getSiteYear( date: Date | number ): number {
}

/**
* Format a date range in the explicit form the section header subtitle uses.
* Format a date range in explicit, readable form, for prominent surfaces.
*
* The shape follows the range's own length: a week or less leads each end with
* its weekday, the year is carried only outside the reference year, and a day
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export function DateComparisonDropdown( {
/*
* Additive: `Compare +` until a preset is picked, then a trigger naming it —
* spelled out rather than a bare `+`, since a glyph alone read as decoration.
* Names the preset, not the period: the section header's subtitle covers that.
* Names the preset, not the period.
*/
return (
<DropdownMenu
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ export {
type SectionTabsProps,
} from './section-tabs/section-tabs';
export { SectionHeader } from './section-header/section-header';
export { getSectionSubtitle } from './section-header/get-section-subtitle';
export { StaleDataNotice } from './stale-data-notice';
export { StatsBreadcrumbs, type StatsBreadcrumbsProps } from './stats-breadcrumbs';
export { StatsPageIcon } from './stats-page-icon';

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { render, screen } from '@testing-library/react';
import { SectionHeader } from '../section-header';

const SUBTITLE = 'Jul 21 – Jul 27 (7 days)';

describe( 'SectionHeader', () => {
it( 'renders the title as a level-2 heading', () => {
render( <SectionHeader title="Traffic" /> );
Expand All @@ -19,20 +17,6 @@ describe( 'SectionHeader', () => {
);
} );

it( 'renders the subtitle when one is given', () => {
render( <SectionHeader title="Traffic" subtitle={ SUBTITLE } /> );

expect( screen.getByText( SUBTITLE ) ).toBeInTheDocument();
} );

it( 'drops the subtitle once there is nothing to describe', () => {
const { rerender } = render( <SectionHeader title="Traffic" subtitle={ SUBTITLE } /> );

rerender( <SectionHeader title="Traffic" /> );

expect( screen.queryByText( SUBTITLE ) ).not.toBeInTheDocument();
} );

it( 'renders the date controls passed to the slot', () => {
render(
<SectionHeader title="Traffic">
Expand Down
Loading
Loading