Repository navigation
VideoPress: add a Home tab to the dashboard - #51522
heydemoura wants to merge 1 commit into
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
8e507df to
5bbd921
Compare
5bbd921 to
fa31d3a
Compare
6c15624 to
ba48b68
Compare
fa31d3a to
87f89be
Compare
ba48b68 to
a9bc70a
Compare
87f89be to
cff91c7
Compare
a9bc70a to
b3587a7
Compare
b7bac8d to
d448a16
Compare
Home greets returning users with their recent videos, view counts and quick actions, and joins the tab strip only once there is something to come back to — on first run the Library's upload empty state is the page, so the strip stays Library-led. The strip's order freezes per mount so the first successful upload can't re-order it mid-flow, and publishing or deleting a last video now lands on Home. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
b3587a7 to
c38fb0f
Compare
| @@ -0,0 +1,269 @@ | |||
| import { useGlobalNotices } from '@automattic/jetpack-components/global-notices'; | |||
| import { Tooltip } from '@wordpress/components'; | |||
There was a problem hiding this comment.
Hi! You can use Tooltip from the @wordpress/ui package instead. It's a more modern version of the same component.
Please also rebase onto the latest trunk; you'll see the new linter rule complain about using the old component until you update. If you must use this older component, you can include it in the linter exclusion list for now. Just lemme know!
|
Lemme know if the PR is still valid or if you'll drop it; I can help review the component usage with latest design system features. I see quite a lot of improvements to be made but don't want to spend time commenting if you'll drop the PR anyway. Cheers! |
Proposed changes
Part 3 of 4 splitting #51481 (welcome modal → Library upload empty state → this PR → follow-up fixes). Based on
add/videopress-library-upload-empty-state.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
jetpack build plugins/jetpack --deps, use a Jetpack-connected site with at least one VideoPress video.jetpack test js packages/videopress— all suites pass.