Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forms: sync new responses to Google Sheets (Jetpack side) #51104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Forms: sync new responses to Google Sheets (Jetpack side) #51104
Changes from 9 commits
c2747a3846c87859a0ed1289204e2f0bdf7b672de14aa47343ae2020de4bc70a018e3efdb6fde1fa6b06File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the
Buttonfrom@wordpress/uiThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of the latest
@wordpress/uipackage version bump in Jetpack, you can now use components for all of these from the@wordpress/uipackage instead.Please also rebase onto the latest
trunk; you'll see the new linter rule complain about using the old components until you update. If you must use this older component, you can include it in the linter exclusion list for now. Just lemme know!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once
spreadsheetIdis set there's no way back into the setup controls — no change spreadsheet, no refresh columns, no disconnect. The header toggle only flipsenabled; it never touchescolumns.Meanwhile the form stays editable. Rename "Phone" to "Mobile" and
build_row()looks up the frozen "Phone", misses, and writes''for every row from then on; the numbers are just dropped. Add a field and its values never reach the sheet at all. Delete one and there's a permanently blank column the user can't remove without hand-editing block attributes. The only recovery is deleting and re-adding the form block, which orphans the first spreadsheet.At minimum, could we compare the stored columns against the form's current labels on render and show a "this form has changed since setup" notice with a re-run action? Even just keeping the setup controls reachable would help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can likely use
Textinstead of custom styles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the newer
Stackinstead ofVstack/HStack.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.