Repository navigation
Forms: replace jetpack buttons with core button - #46166
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 3 files.
Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
82662a1 to
ef3b913
Compare
ef3b913 to
9efe006
Compare
0678483 to
9f31eb8
Compare
9f31eb8 to
601278c
Compare
2fd600b to
5bbcc12
Compare
…ped it fixes the input/button height parity on all themes
…tton markup to add the error wrapper
…rategy for all buttons
b1197ca to
a716098
Compare
| border: 2px solid currentColor; | ||
| border-right-color: transparent; | ||
| border-radius: 50%; | ||
| animation: jp-forms-submit-spinner 0.75s linear infinite; |
There was a problem hiding this comment.
This adds a second spinner next to each button.
We should either remove this one or the one that is in the HTML since they there is really no need to have two.
There was a problem hiding this comment.
This is a takeover from #45007
Resolves FORMS-83
Proposed changes:
Following the original PR, this is a simpler approach just using core/button to replace jetpack/button
Other information:
Jetpack product discussion
None
Does this pull request change what data or activity we track or use?
No
Testing instructions:
(verbatim from original PR)
Existing post smoke-test
New form
Variations
Editor layout