Skip to content

Forms: replace jetpack buttons with core button - #46166

Merged
CGastrell merged 36 commits into
trunkfrom
replace/forms-jetpack-buttons-core
Dec 29, 2025
Merged

CGastrell merged 36 commits into
trunkfrom
replace/forms-jetpack-buttons-core

Conversation

@CGastrell

@CGastrell CGastrell commented Dec 2, 2025 •

Copy link
Copy Markdown
Contributor

This is a takeover from #45007

Resolves FORMS-83

Proposed changes:

Following the original PR, this is a simpler approach just using core/button to replace jetpack/button

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

(verbatim from original PR)

  1. Existing post smoke-test

    • Open a post containing a Contact Form created before this patch (uses Jetpack Button).
    • Confirm there are no editor errors; publish / update.
    • View front-end and submit the form – it should behave as it always did.
  2. New form

    • Insert a fresh Contact Form block.
    • Verify the submit control is a Core Button in a Core Buttons wrapper.
    • Publish and submit on the front-end – spinner, disable state and success/error handling should work.
  3. Variations

    • Insert each Contact-Form variation (RSVP, Registration, Feedback, etc.).
    • Confirm each uses a Core Button and submits correctly.
  4. Editor layout

    • Editing experience should respect the different core/block options when saving.

@CGastrell CGastrell self-assigned this Dec 2, 2025
@CGastrell CGastrell added [Status] Needs Review This PR is ready for review. Task [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Package] Forms Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR labels Dec 2, 2025
@github-actions github-actions Bot added [Block] Form Form block (also see Form package label) [Feature] Forms [Tests] Includes Tests labels Dec 2, 2025
@github-actions

github-actions Bot commented Dec 2, 2025 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: January 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions

github-actions Bot commented Dec 2, 2025 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the replace/forms-jetpack-buttons-core branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack replace/forms-jetpack-buttons-core

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control

jp-launch-control Bot commented Dec 2, 2025 •

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form.php 968/1397 (69.29%) -1.50% 30 💔
projects/packages/forms/src/blocks/contact-form/edit.tsx 0/276 (0.00%) 0.00% 3 ❤️‍🩹
projects/packages/forms/src/blocks/contact-form/class-contact-form-block.php 507/592 (85.64%) 3.21% -19 💚

Full summary · PHP report · JS report

Coverage check overridden by Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR .

@CGastrell
CGastrell force-pushed the replace/forms-jetpack-buttons-core branch from 82662a1 to ef3b913 Compare December 2, 2025 15:53
Comment thread projects/packages/forms/src/contact-form/class-util.php Outdated
@CGastrell
CGastrell force-pushed the replace/forms-jetpack-buttons-core branch from ef3b913 to 9efe006 Compare December 3, 2025 15:20
Comment thread projects/packages/forms/src/blocks/contact-form/edit.tsx Outdated
Comment thread projects/packages/forms/src/blocks/contact-form/editor.scss Outdated
Comment thread projects/packages/forms/src/contact-form/class-contact-form.php Outdated
Comment thread projects/packages/forms/src/contact-form/css/grunion.scss Outdated
@CGastrell
CGastrell force-pushed the replace/forms-jetpack-buttons-core branch 3 times, most recently from 0678483 to 9f31eb8 Compare December 11, 2025 16:32
@CGastrell
CGastrell force-pushed the replace/forms-jetpack-buttons-core branch from 9f31eb8 to 601278c Compare December 15, 2025 17:17
Comment thread projects/packages/forms/src/blocks/shared/hooks/use-form-wrapper.js Outdated
Comment thread projects/packages/forms/src/blocks/contact-form/class-contact-form-block.php Outdated
@CGastrell
CGastrell force-pushed the replace/forms-jetpack-buttons-core branch 2 times, most recently from 2fd600b to 5bbcc12 Compare December 17, 2025 18:55
@CGastrell
CGastrell force-pushed the replace/forms-jetpack-buttons-core branch from b1197ca to a716098 Compare December 22, 2025 19:46
@CGastrell
CGastrell merged commit 944b1d0 into trunk Dec 29, 2025
70 checks passed
@CGastrell
CGastrell deleted the replace/forms-jetpack-buttons-core branch December 29, 2025 15:12
@github-actions github-actions Bot added this to the jetpack/15.4 milestone Dec 29, 2025
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Dec 29, 2025
border: 2px solid currentColor;
border-right-color: transparent;
border-radius: 50%;
animation: jp-forms-submit-spinner 0.75s linear infinite;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a second spinner next to each button.
We should either remove this one or the one that is in the HTML since they there is really no need to have two.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simison simison changed the title Forms: replace jetpack buttons with core Forms: replace jetpack buttons with core button Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Form Form block (also see Form package label) Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR [Feature] Forms [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Task [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants