Skip to content

Conversation

@dilirity
Copy link
Member

@dilirity dilirity commented Oct 30, 2025

Fixes HOG-396

We do this for Cloud CSS as well, but I didn't want to touch it as we have job deferring and the payload is merged.

Proposed changes:

  • Simplify the job ID to prevent the same job from being enqueued multiple times.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

HOG-396

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • This is easiest tested with local boost cloud;
  • Setup Boost and enable LCP;
  • Keep an eye on the logs - there should be entries about the job being enqueued and processed;
  • Stop the worker for the LCP service (boost-hydra-lcp). This will prevent the jobs from being processed and you'll be able to observe the queue easily;
  • Toggle the LCP analysis multiple times and pay attention to the request ID;
  • If you're using trunk/production Boost, you should see a different request ID every time you toggle the feature;
  • If you're using this branch, you should see the same request ID when you toggle the feature. That's assuming you didn't update the cornerstone pages list.

@dilirity dilirity self-assigned this Oct 30, 2025
@dilirity dilirity added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Plugin] Boost A feature to speed up the site and improve performance. I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Boost Feature] Lcp labels Oct 30, 2025
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Oct 30, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@dilirity
Copy link
Member Author

dilirity commented Nov 3, 2025

Merging this as it's a trivial change.

@dilirity dilirity merged commit 6f513a3 into trunk Nov 3, 2025
72 checks passed
@dilirity dilirity deleted the update/boost/lcp/prevent-same-payload-belonging-to-multiple-jobs branch November 3, 2025 08:20
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Boost Feature] Lcp I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Plugin] Boost A feature to speed up the site and improve performance. [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants