Skip to content

Conversation

@lezama
Copy link
Contributor

@lezama lezama commented Oct 30, 2025

Fixes #

Proposed changes:

  • Changes multistep forms to default to single step view instead of showing all steps inline

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Before these changes:

  • Multistep forms opened showing all steps inline by default
  • Clicking next/previous buttons or selecting a step from the dropdown caused the viewport to jump to that step block

After these changes:

  • Multistep forms open in single step view showing only the first step
  • Navigation between steps is smooth without viewport jumping
  • Users can still switch to "All steps" view via the dropdown menu when needed

Steps to test:

Play with multistep forms

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/mulistep-form-default-step branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/mulistep-form-default-step

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 30, 2025
@lezama lezama requested a review from a team October 30, 2025 00:34
@jp-launch-control
Copy link

jp-launch-control bot commented Oct 30, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/blocks/contact-form/edit.tsx 0/271 (0.00%) 0.00% 3 ❤️‍🩹
projects/packages/forms/src/blocks/shared/components/form-step-controls/index.js 0/24 (0.00%) 0.00% -2 💚

Full summary · PHP report · JS report

@lezama lezama force-pushed the update/mulistep-form-default-step branch from e29e061 to a4114f8 Compare October 30, 2025 00:45
@lezama lezama force-pushed the update/mulistep-form-default-step branch from a4114f8 to c0b58f6 Compare October 30, 2025 00:47
Copy link
Contributor

@edanzer edanzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me. I think there was some discussion on Slack that it might be hard for user to immediately understand how to navigate between steps this way, but the front/back arrows on toolbar seem fairly clear to me by block editor standards.

Here's what I get when inserting a new multistep form block:
multistep-single-step-view

@lezama lezama merged commit 59760d4 into trunk Nov 3, 2025
67 checks passed
@lezama lezama deleted the update/mulistep-form-default-step branch November 3, 2025 11:03
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants