Skip to content

a4a dashboard: mark external link as external #43167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeherve merged 2 commits into from
Apr 26, 2025
Merged

a4a dashboard: mark external link as external #43167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e96f964
a4a dashboard: mark external link as external
jeherve Apr 21, 2025
b0dd67f
Merge remote-tracking branch 'origin/trunk' into update/external-link…
jeherve Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/automattic-for-agencies-client/changelog/update-external-links-a8c-plugin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Dashboard: mark external link as external.
5 changes: 2 additions & 3 deletions projects/plugins/automattic-for-agencies-client/src/js/components/connection-card/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { getRedirectUrl } from '@automattic/jetpack-components';
import { ConnectButton } from '@automattic/jetpack-connection';
import { ExternalLink } from '@wordpress/components';
import { createInterpolateElement } from '@wordpress/element';
import { __ } from '@wordpress/i18n';
import clsx from 'clsx';
Expand Down Expand Up @@ -66,11 +67,9 @@ function ConnectionContent( { onShowSharingDetailsClick } ) {
{
strong: <strong />,
tosLink: (
<a
<ExternalLink
className={ styles[ 'terms-of-service__link' ] }
href={ getRedirectUrl( 'wpcom-tos' ) }
rel="noopener noreferrer"
target="_blank"
/>
),
shareDetailsLink: (
Expand Down
11 changes: 5 additions & 6 deletions ...ugins/automattic-for-agencies-client/src/js/components/connection-card/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
line-height: 32px;
}
}

h2 {
font-size: 32px;
line-height: 35px;
Expand All @@ -31,7 +31,7 @@
line-height: 32px;
}
}

p {
margin: 0;
}
Expand All @@ -56,7 +56,7 @@
line-height: 32px;
}
}

h2 {
font-size: 32px;
line-height: 35px;
Expand All @@ -67,7 +67,7 @@
line-height: 32px;
}
}

p {
margin: 0;
}
Expand Down Expand Up @@ -135,13 +135,12 @@
font-size: 13px;
color: var(--jp-black);
max-width: 460px;

}

.terms-of-service__link {
color: $studio-automattic-blue;
white-space: nowrap;
text-decoration: underline;
}

:global {
Expand Down