-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: Allow non admin users #42750
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 2 files.
|
Update the way we handle data and block interface on Jetpack AI. Right now, we look if the current user is connected, but if the user isn't an admin, it won't be connected, but the site will be. Since Jetpack AI is site-based and not user-based, we should to make our logic site-based.
More context: pe4Cmx-37K-p2
Proposed changes:
is_connected
.isRegistered
.permission_callback
forai-assistant-feature
request.Other information:
Jetpack product discussion
pe4Cmx-37K-p2
Does this pull request change what data or activity we track or use?
N/A
Testing instructions:
Since we're changing the way we block/allow things, we need to review all our features and test them with both admin and non-admin users (like editors).
Below is a list of our current features:
Please go through all these features and play with admin, non-admin users, and not connected site.