Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack AI: Allow non admin users #42750

Closed
wants to merge 13 commits into from
Closed

Conversation

renatoagds
Copy link
Contributor

@renatoagds renatoagds commented Mar 27, 2025

Update the way we handle data and block interface on Jetpack AI. Right now, we look if the current user is connected, but if the user isn't an admin, it won't be connected, but the site will be. Since Jetpack AI is site-based and not user-based, we should to make our logic site-based.

More context: pe4Cmx-37K-p2

Proposed changes:

  • Move all connection manager logic to check for is_connected.
  • Move all UI logic to check for isRegistered.
  • Remove the permission_callback for ai-assistant-feature request.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pe4Cmx-37K-p2

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

Since we're changing the way we block/allow things, we need to review all our features and test them with both admin and non-admin users (like editors).

Below is a list of our current features:

  • AI Assistant Block
  • Voice to Content
  • Excerpt
  • Post Feedback
  • Write Brief
  • SEO Enhancer
  • Title Generation
  • AI Image
  • Text Block Extension
  • Image Block Extension

Please go through all these features and play with admin, non-admin users, and not connected site.

@renatoagds renatoagds requested a review from a team March 27, 2025 19:48
@renatoagds renatoagds self-assigned this Mar 27, 2025
@github-actions github-actions bot added [Block] AI Assistant [Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Mar 27, 2025
Copy link
Contributor

github-actions bot commented Mar 27, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented Mar 27, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the feature/ai-assistant-editor branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack feature/ai-assistant-editor

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link

jp-launch-control bot commented Mar 27, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/blocks/ai-assistant/extensions/lib/can-ai-assistant-be-enabled.ts 0/16 (0.00%) 0.00% 1 ❤️‍🩹
projects/plugins/jetpack/_inc/lib/class-jetpack-ai-helper.php 0/206 (0.00%) 0.00% -5 💚

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] AI Assistant [Extension] AI Content Lens [Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant