Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Include jetpack_vendor dirs in jetpack clean vendor #42744

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Mar 27, 2025

Proposed changes:

When selecting the "vendor" option for jetpack clean, "jetpack_vendor" dirs should also be removed.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Try it out in various combinations.

When selecting the "vendor" option for `jetpack clean`, "jetpack_vendor"
dirs should also be removed.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] Normal labels Mar 27, 2025
@anomiex anomiex requested a review from a team March 27, 2025 15:27
@anomiex anomiex self-assigned this Mar 27, 2025
@github-actions github-actions bot added the [Tools] Development CLI The tools/cli to assist during JP development. label Mar 27, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@anomiex anomiex merged commit 47b3059 into trunk Mar 31, 2025
63 checks passed
@anomiex anomiex deleted the fix/cli-clean-vendor-jetpack_vendor branch March 31, 2025 17:17
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Tools] Development CLI The tools/cli to assist during JP development. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants