Skip to content

Paid/Premium blocks: Fix cover block alignments on free sites #35028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miksansegundo merged 3 commits into from
Jan 16, 2024
Merged

Paid/Premium blocks: Fix cover block alignments on free sites #35028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84ebd02
Fix for alignfull cover block on free sites due to paid block upgrade…
miksansegundo Jan 15, 2024
6b0c7a6
changelog
miksansegundo Jan 15, 2024
dfbc566
Use max-width unset
miksansegundo Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/fix-paid-blocks-upgrade-nudge-break-cover-block-free
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

Payment blocks: Fix cover block alignments on free sites
4 changes: 3 additions & 1 deletion projects/plugins/jetpack/extensions/extended-blocks/paid-blocks/with-upgrade-banner.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,15 @@ const withUpgradeBanner = createHigherOrderComponent(
}, [ setAttributes, hasParentBanner ] );

const blockProps = useBlockProps();
// Fix for width of cover block because otherwise the div defaults to content-size as max width
const cssFixForCoverBlock = { 'max-width': 'unset' };

return (
<PaidBlockProvider
onBannerVisibilityChange={ setIsVisible }
hasParentBanner={ isBannerVisible }
>
<div ref={ blockProps.ref }>
<div ref={ blockProps.ref } style={ cssFixForCoverBlock }>
<UpgradePlanBanner
className={ `is-${ name.replace( /\//, '-' ) }-paid-block` }
title={ null }
Expand Down