Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Fix depreciation notice wp_print_styles WP 6.4 #33680

Closed
wants to merge 2 commits into from

Conversation

haqadn
Copy link
Contributor

@haqadn haqadn commented Oct 19, 2023

⚠️ I am still trying to figure out if we really need this.

Core seems to have found a weird way to deprecate print_emoji_styles. Even though print_emoji_styles itself isn't depricated, using it without this hack may still produce deprication notice.

Related to #33655

See WordPress/gutenberg#54806 and WordPress/gutenberg#54828

Proposed changes:

  • Temporarily remove action call to print_emoji_styles while using wp_print_styles

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Install WP 6.4 beta
  • Generate critical CSS and ensure no deprication notice is present related to print_emoji_styles.

Temporarily remove action call to `print_emoji_styles` while using `wp_print_styles`
@haqadn haqadn changed the title Fix compatibility issue with wp_print_styles WP 6.4 Boost: Fix compatibility issue with wp_print_styles WP 6.4 Oct 19, 2023
@haqadn haqadn changed the title Boost: Fix compatibility issue with wp_print_styles WP 6.4 Boost: Fix depreciation notice wp_print_styles WP 6.4 Oct 19, 2023
@github-actions github-actions bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Oct 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: November 7, 2023.
  • Scheduled code freeze: October 30, 2023.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 19, 2023
@haqadn haqadn added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Oct 19, 2023
@haqadn
Copy link
Contributor Author

haqadn commented Oct 25, 2023

Not actually needed

@haqadn haqadn closed this Oct 25, 2023
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant