-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Turn off autoplay if hover effect's active #30663
[RNMobile] Turn off autoplay if hover effect's active #30663
Conversation
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run
to get started. More details: p9dueE-5Nn-p2 |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 ! I tested using WordPress/gutenberg#50560 in Gutenberg and confirmed these changes work as expected.
Significance: patch | ||
Type: fixed | ||
|
||
RNMobile: Turn off autoplay if poster hover effect's active |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea bout adding RNMobile
in the logs, I noticed when checking the VideoPress CHANGELOG that it's not clear which ones only impact the native version. Maybe we can take this as a standard for future PRs, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good by me! :)
…30663) Turn off autoplay setting if preview on hover effect's active
Note, the change in this PR is dependant on the changes in WordPress/gutenberg#50560.
Proposed changes:
Other information:
Jetpack product discussion
p1683840917884969-slack-C03TA48NSUX
Does this pull request change what data or activity we track or use?
No, it does not.
Testing instructions: