Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Turn off autoplay if hover effect's active #30663

Merged
merged 2 commits into from
May 12, 2023

Conversation

SiobhyB
Copy link

@SiobhyB SiobhyB commented May 11, 2023

Note, the change in this PR is dependant on the changes in WordPress/gutenberg#50560.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1683840917884969-slack-C03TA48NSUX

Does this pull request change what data or activity we track or use?

No, it does not.

Testing instructions:

  • On the web: Navigate to the editor for a post with an existing VideoPress block or go through the steps to add a new one.
  • In the Post and preview section of the block's settings, toggle the Video preview on hover option on.
  • Verify that the autoplay setting is no longer usable under the Playback section and save the post.
  • In the app: Navigate to the editor for the post you just saved.
  • Tap on the VideoPress block to then open its settings.
  • Select Playback Settings and verify that the autoplay setting is no longer usable. It should display the same note as the web.
Before After

@SiobhyB SiobhyB self-assigned this May 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack rnmobile/videopress-conditionally-disable-autoplay

to get started. More details: p9dueE-5Nn-p2

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@SiobhyB SiobhyB changed the title [RNMobile] videopress conditionally disable autoplay [RNMobile] Turn off autoplay if hover effect's active May 11, 2023
@SiobhyB SiobhyB requested review from fluiddot and jhnstn May 12, 2023 07:48
@SiobhyB SiobhyB marked this pull request as ready for review May 12, 2023 09:49
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 ! I tested using WordPress/gutenberg#50560 in Gutenberg and confirmed these changes work as expected.

Significance: patch
Type: fixed

RNMobile: Turn off autoplay if poster hover effect's active
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea bout adding RNMobile in the logs, I noticed when checking the VideoPress CHANGELOG that it's not clear which ones only impact the native version. Maybe we can take this as a standard for future PRs, WDYT?

cc @SiobhyB @jhnstn

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good by me! :)

@SiobhyB SiobhyB merged commit 68308fa into trunk May 12, 2023
@SiobhyB SiobhyB deleted the rnmobile/videopress-conditionally-disable-autoplay branch May 12, 2023 16:23
markbiek pushed a commit that referenced this pull request May 12, 2023
…30663)

Turn off autoplay setting if preview on hover effect's active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants