Skip to content

CLI: Cleanup release command next messages #28041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coder-karen merged 2 commits into from
Dec 22, 2022
Merged

CLI: Cleanup release command next messages #28041

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d989c1
Cleanup CLI next steps for tooling
sdixon194 Dec 21, 2022
5aff938
Fix a typo
sdixon194 Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions tools/cli/commands/release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,38 +136,27 @@ export async function scriptRouter( argv ) {
argv.scriptArgs.unshift( '-b' );
}
argv.addPrNum && argv.scriptArgs.unshift( '-p' );
argv.next = `Finished! Next: \n - Create the "prerelease" branch off trunk (if not already on that branch), review the changes, make any necessary adjustments. \n - Commit your changes. \n - To continue with the release process (unless it's an Atomic release), update the readme.txt by running:\n jetpack release ${ argv.project } readme \n`;
argv.next = `Finished! You may want to update the readme.txt by running 'jetpack release ${ argv.project } readme' \n`;
break;
case 'readme':
argv.script = `tools/plugin-changelog-to-readme.sh`;
argv.scriptArgs = [ argv.project ];
argv.next = `Finished! Next:
- If this is a beta, ensure the stable tag in readme.txt is latest stable.
- Create a PR and have your changes reviewed and merged.
- Wait and make sure changes are propagated to mirror repos for each updated package.
- After propagation, if you need to create a release branch, stand on "prerelease" and then run:
jetpack release ${ argv.project } release-branch \n`.replace( /^\t+/gm, '' );
argv.next = 'Finished updating readme!';
break;
case 'release-branch':
argv.version = await getReleaseVersion( argv );
argv = await promptForVersion( argv );
argv.script = `tools/create-release-branch.sh`;
argv.scriptArgs = [ argv.project, argv.version ];
argv.next = `Finished! Next:
- Once the branch is pushed, GitHub Actions will build and create a branch on your plugin's mirror repo.
- That mirror repo branch will be the branch that is tagged in GitHub and pushed to svn in WordPress.org.
- When changes are pushed to the release branch that was just created, GitHub Actions takes care of building/mirroring to the mirror repo.
- You will now likely want to start a new release cycle like so:
jetpack release ${ argv.project } new-cycle \n`.replace( /^\t+/gm, '' );
argv.next = 'Release branch pushed!';
break;
case 'amend':
await checkBranchValid( argv );
argv.script = `vendor/bin/changelogger`;
argv.scriptArgs = [ `write`, `--amend` ];
argv.addPrNum && argv.scriptArgs.push( '--add-pr-num' );
argv.workingDir = `projects/${ argv.project }`;
argv.next = `Finished! Next:
- You will now likely want to update readme.txt again, then commit to the release branch:
argv.next = `Finished! You will now likely want to update readme.txt again:
jetpack release ${ argv.project } readme \n`.replace( /^\t+/gm, '' );
break;
case 'version':
Expand Down