Skip to content

Fix importing global base styles in Jetpack beta extension label - #28039

Closed
simison wants to merge 2 commits into
trunkfrom
fix/global-css
Closed

simison wants to merge 2 commits into
trunkfrom
fix/global-css

Conversation

@simison

@simison simison commented Dec 21, 2022 •

Copy link
Copy Markdown
Member

Part of #28038

Changes proposed in this Pull Request:

There's more work to fix such globally applied styles but this already helps.

I don't know how to test this PR and how the original imported styles exactly were affecting the feature; hence this probably needs more work. Is it just that --jp-green-30 color?

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@simison simison added the Bug When a feature is broken and / or not performing as intended label Dec 21, 2022
@github-actions github-actions Bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Dec 21, 2022
@github-actions

github-actions Bot commented Dec 21, 2022 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: January 3, 2023.
  • Scheduled code freeze: December 26, 2022.

@github-actions

github-actions Bot commented Dec 21, 2022 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack fix/global-css to get started. More details: p9dueE-5Nn-p2

@coder-karen

Copy link
Copy Markdown
Contributor

Went straight to the source here after testing other features that import the style - #28024 - so this new PR shouldn't be needed any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants