Skip to content

Add missing attributes to form - #28029

Merged
millerf merged 2 commits into
paid-newslettersfrom
fix/add-missing-attributes-to-form
Dec 21, 2022
Merged

millerf merged 2 commits into
paid-newslettersfrom
fix/add-missing-attributes-to-form

Conversation

@romarioraffington

Copy link
Copy Markdown
Contributor

Testing instructions:

  • Pull PR
  • Verify the subscribe blog works as expected in the jetpack environment

@romarioraffington
romarioraffington changed the base branch from trunk to paid-newsletters December 20, 2022 22:56
@romarioraffington
romarioraffington requested a review from a team December 20, 2022 22:56
@github-actions

github-actions Bot commented Dec 20, 2022 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack fix/add-missing-attributes-to-form to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions Bot added [Block] Subscribe [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Dec 20, 2022
@github-actions

github-actions Bot commented Dec 20, 2022 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • 🔴 Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please edit your PR description and explain what functional changes your PR includes, and why those changes are needed.


🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

#### Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: January 3, 2023.
  • Scheduled code freeze: December 26, 2022.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 20, 2022

@millerf millerf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me :shipit:
Screenshot 2022-12-21 at 09 26 19
Screenshot 2022-12-21 at 09 26 43

<?php endif; ?>
>
<input type="hidden" name="action" value="subscribe"/>
<input type="hidden" name="blog_id" value="<?php echo (int) $blog_id; ?>"/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if that is actually needed.

@millerf
millerf merged commit 8917fe1 into paid-newsletters Dec 21, 2022
@millerf
millerf deleted the fix/add-missing-attributes-to-form branch December 21, 2022 08:30
@github-actions github-actions Bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 21, 2022
@coder-karen coder-karen added this to the Jetpack 11.7 milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Subscribe [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants