Skip to content

Removing box-sizing:border-box from Base Styles #28024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coder-karen merged 4 commits into from
Dec 21, 2022
Merged

Removing box-sizing:border-box from Base Styles #28024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
821245d
Removing box-sizing:border-box from Base Styles
coder-karen Dec 20, 2022
2077310
changelog
coder-karen Dec 20, 2022
9b487e4
Merge remote-tracking branch 'origin/trunk' into fix/base-styles-box-…
coder-karen Dec 21, 2022
4c3f929
Updating package versions
coder-karen Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/js-packages/base-styles/changelog/fix-base-styles-box-sizing
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Base styles: Removed box-sizing which caused a style issue in the customizer-themes dashboard.
2 changes: 1 addition & 1 deletion projects/js-packages/base-styles/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@automattic/jetpack-base-styles",
"version": "0.3.16",
"version": "0.3.17-alpha",
"description": "Jetpack components base styles",
"homepage": "https://github.com/Automattic/jetpack/tree/HEAD/projects/js-packages/base-styles/#readme",
"bugs": {
Expand Down
4 changes: 0 additions & 4 deletions projects/js-packages/base-styles/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@
/********* Generic styles *********/
$wp-gray-dark: #23282d;

* {
box-sizing: border-box;
}

body {
min-height: 100%;
margin: 0;
Expand Down