Skip to content

pr-is-up-to-date: Speed up processing of tag pushes with paths - #23123

Merged
anomiex merged 1 commit into
masterfrom
fix/pr-up-to-date-workflow-timeout
Feb 25, 2022
Merged

anomiex merged 1 commit into
masterfrom
fix/pr-up-to-date-workflow-timeout

Conversation

@anomiex

@anomiex anomiex commented Feb 25, 2022

Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request:

When processing a tag push and PATHS is set, we need to find the merge
base to get the diff to determine if the paths are touched.

But it's a lot faster to fetch 100 revisions at once than to fetch 10
revisions 10 times. So instead of fetching to each PR's merge base,
which will likely enough fetch a few revisions for every PR beyond a
certain age, fetch arbitrary blocks of revisions.

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • You could set the relevant environment variables and run the script manually. Or merge then watch the run on the next tag push.

When processing a tag push and PATHS is set, we need to find the merge
base to get the diff to determine if the paths are touched.

But it's a lot faster to fetch 100 revisions at once than to fetch 10
revisions 10 times. So instead of fetching to each PR's merge base,
which will likely enough fetch a few revisions for every PR beyond a
certain age, fetch arbitrary blocks of revisions.
@anomiex anomiex self-assigned this Feb 25, 2022
@github-actions github-actions Bot added [Action] PR Is Up To Date Actions GitHub actions used to automate some of the work around releases and repository management labels Feb 25, 2022
@github-actions

github-actions Bot commented Feb 25, 2022 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 25, 2022
@anomiex
anomiex merged commit 870b0e6 into master Feb 25, 2022
@anomiex
anomiex deleted the fix/pr-up-to-date-workflow-timeout branch February 25, 2022 18:58
@github-actions github-actions Bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Action] PR Is Up To Date Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants