Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-test-runner: Add WorDBless dir to jest collectCoverageFrom #22472

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 24, 2022

Changes proposed in this Pull Request:

The coverage report started taking an extra 10 minutes after
packages/my-jetpack added JS tests because it was reporting coverage for
all of WordPress that was brought in via WorDBless. Exclude that by
default.

Also exclude the jetpack_vendor/ directory from
packages/composer-plugin for good measure.

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • In the "Tests / Code coverage" job, check that the JS tests for packages/my-jetpack take closer to 5 seconds than 580.

The coverage report started taking an extra 10 minutes after
packages/my-jetpack added JS tests because it was reporting coverage for
all of WordPress that was brought in via WorDBless. Exclude that by
default.

Also exclude the `jetpack_vendor/` directory from
packages/composer-plugin for good measure.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels Jan 24, 2022
@anomiex anomiex self-assigned this Jan 24, 2022
@anomiex anomiex enabled auto-merge (squash) January 24, 2022 17:43
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@anomiex anomiex merged commit eee7003 into master Jan 24, 2022
@anomiex anomiex deleted the fix/js-test-runner-jest-collectCoverageFrom branch January 24, 2022 18:18
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 24, 2022
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 24, 2022
samiff pushed a commit that referenced this pull request Jan 28, 2022
…ageFrom (#22472)

The coverage report started taking an extra 10 minutes after
packages/my-jetpack added JS tests because it was reporting coverage for
all of WordPress that was brought in via WorDBless. Exclude that by
default.

Also exclude the `jetpack_vendor/` directory from
packages/composer-plugin for good measure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants