Repository navigation
babel-plugin-replace-textdomain: Replace missing domains too - #22077
Conversation
It should also fix up calls with no domain parameter at all, like
`__('foo')`.
Also, clean up the code a bit, and actually replace the nodes instead of
munging the value (which I'm not sure is actually supported).
|
Caution: This PR has changes that must be merged to WordPress.com |
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
kraftbj
left a comment
There was a problem hiding this comment.
I'd rather us not have code in our repo that lacks a textdomain, but that's not a blocker for this.
|
We could always have linter rules or the like that require this to be fixed in our own code. But I figured this was quicker than chasing after a missing domain in a Calypso package. Looking at their other code now, they seem to have a mix of not using domains at all and passing |
|
Great news! One last step: head over to your WordPress.com diff, D71391-code, and commit it. Thank you! |
|
r236554-wpcom |
Changes proposed in this Pull Request:
It should also fix up calls with no domain parameter at all, like
__('foo').Also, clean up the code a bit, and actually replace the nodes instead of
munging the value (which I'm not sure is actually supported).
Jetpack product discussion
PT: p9dueE-3MG-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions: