Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets: add aria-current attribute to links when on same page #13831

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Widgets: add aria-current attribute to links when on same page #13831

merged 2 commits into from
Oct 28, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Oct 24, 2019

Changes proposed in this Pull Request:

Testing instructions:

  • Both the Stats module and the Widgets module should be active on your site.
  • Visit a few of your posts while logged out to make sure some of your posts will appear in your Top Posts widget later on.
  • Go to Appearance > Widgets, and add both the Authors and the Top Posts widget to your site.
  • Visit your site. When you are on a page listed in one of the widgets, the link in the widget should include a aria-current="page" attribute.

Proposed changelog entry for your changes:

  • Widgets: add aria-current attribute to links when on same page

@jeherve
Widgets: add aria-current attribute to links when on same page
3e38b0b 
This brings our 2 widgets currently outputting internal links (Authors and Top Posts) up to date with Core's accessibility improvements:
https://core.trac.wordpress.org/ticket/47094
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Focus] Accessibility Improving usability for all users (a11y) [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels Oct 24, 2019
@jeherve jeherve added this to the 7.9 milestone Oct 24, 2019
@jeherve jeherve requested a review from a team as a code owner October 24, 2019 14:21
@jeherve jeherve self-assigned this Oct 24, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D34462-code before merging this PR. Thank you!

@jeherve jeherve mentioned this pull request Oct 24, 2019
Closed
11 tasks
@jetpackbot
Copy link

jetpackbot commented Oct 24, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 9add752

kraftbj
kraftbj requested changes Oct 25, 2019
View reviewed changes
modules/widgets/authors.php Outdated Show resolved Hide resolved
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 26, 2019
@jeherve jeherve merged commit cb04cfc into master Oct 28, 2019
@jeherve jeherve deleted the update/current-links-widgets branch October 28, 2019 10:56
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 28, 2019
jeherve added a commit that referenced this pull request Oct 28, 2019
@jeherve
Changelog: add #13831
18d6b0c
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Extra Sidebar Widgets [Focus] Accessibility Improving usability for all users (a11y) [Pri] Normal Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @matticbot @jetpackbot @kraftbj