Logo Gallery block #11986
Logo Gallery block #11986
Conversation
frontdevde
added
[Status] In Progress
[Focus] Blocks
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import registerJetpackBlock from '../../utils/register-jetpack-block'; |
There was a problem hiding this comment.
Note that we've moved files a bit around, utils are now under /extensions/shared. Please rebase. :-)
| list-style-type: none; | ||
| } | ||
|
|
||
| .logo-gallery-item { |
There was a problem hiding this comment.
You might want to protect this from leaking out to other "logo-gallery" blocks (by others than us) by wrapping it in wp-block-jetpack-logo-gallery
| @@ -18,5 +18,5 @@ | |||
| "videopress", | |||
| "wordads" | |||
| ], | |||
| "beta": [ "likes", "sharing", "seo" ] | |||
| "beta": [ "likes", "sharing", "seo", "logo-gallery" ] | |||
There was a problem hiding this comment.
This json file got moved to extensions/index.json. Please rebase. :-)
| function jetpack_logo_gallery_block_load_assets( $attr, $content ) { | ||
| $dependencies = array(); | ||
|
|
||
| Jetpack_Gutenberg::load_assets_as_required( 'logo-gallery', $dependencies ); |
There was a problem hiding this comment.
If you don't have need to load view.js, you can use Jetpack_Gutenberg::load_styles_as_required to avoid it.
| * @return string | ||
| */ | ||
| function jetpack_logo_gallery_block_load_assets( $attr, $content ) { | ||
| $dependencies = array(); |
There was a problem hiding this comment.
Empty deps array can prolly be just removed.
|
This PR has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
|
Closing because of change of priorities. |
Changes proposed in this Pull Request:
This block is similar to the Gallery with a few differences:
wp-pafL3P-o0andwp-p8F0Ux-1xQScreenshot of current progress
Updated Icons
Testing instructions:
Proposed changelog entry for your changes:
TODOs