Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): created framework for correcting common phrases #550

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

elijah-potter
Copy link
Collaborator

@elijah-potter elijah-potter commented Jan 31, 2025

In the interest of #472 and #507, I've implemented a framework for correcting minor errors in common phrases. If anyone has any suggestions for more phrases that could in here, I'm all 👂s.

The current list is around line 70 of phrase_corrections.rs.

@elijah-potter elijah-potter merged commit 1770fa9 into master Jan 31, 2025
17 checks passed
@elijah-potter elijah-potter deleted the phrase-corrections branch January 31, 2025 18:09
@jvoisin
Copy link

jvoisin commented Feb 2, 2025

If anyone has any suggestions for more phrases that could in here, I'm all 👂s.

On top of my head:

  • all for not → all for naught
  • biting your time → biding your time
  • brother in laws → brothers in law
  • choke it up → chalk it up
  • could care less → couldn't care less
  • do diligence → due diligence
  • escape goat → scapegoat
  • extract revenge → exact revenge
  • fall by the waste side → fall by the wayside
  • first-come, first-serve → first-come, first-served
  • first-year anniversary → first anniversary
  • free reign → free rein
  • honed in → homed in
  • nipped in the butt → nipped in the bud
  • peak my interest → pique my interest
  • piece of mind → peace of mind
  • safety deposit box → safe deposit box
  • slight of hand → sleight of hand
  • statue of limitations → statute of limitations
  • throws of passion → throes of passion
  • tongue and cheek → tongue in cheek
  • wet your appetite → whet your appetite
  • without further adieu → without further ado
  • wreck havoc → wreak havoc

@hippietrail
Copy link
Contributor

hippietrail commented Feb 2, 2025

More:

  • and alike → and the like
  • backclash → backlash
  • bad rep → bad rap
  • baited breath → bated breath
  • beckon call → beck and call
  • case and point → case in point
  • change tact → change tack
  • could of → could have
  • death nail → death knell
  • deep-seeded → deep-seated
  • fun in games → fun and games
  • hunger pain → hunger pang
  • in mass → en masse
  • let along → let alone
  • long and behold → lo and behold
  • mute point → moot point
  • on mass → en masse
  • pour over → pore over
  • ride off → write off
  • ride-off → write-off
  • should of → should have
  • sneaky suspicion → sneaking suspicion
  • stock and trade → stock in trade
  • stock-and-trade → stock-in-trade
  • supposed to → suppose to
  • sure up → shore up
  • tender hooks → tenter hooks
  • through great lengths → to great lengths
  • tow the line → toe the line
  • viscous circle → vicious circle
  • viscous cycle → vicious cycle
  • vocal chords → vocal cords
  • would of → would have

Can they be enabled/disabled independently? Because some have become so entrenched that their users will probably want to keep using them:

  • butt naked → buck naked
  • invest into → invest in
  • Jerry-rigged
    → Jerry-built
    → jury-rigged
  • on accident → by accident
  • vicious cycle → vicious circle

@hippietrail
Copy link
Contributor

If anyone has any suggestions for more phrases that could in here, I'm all 👂s.

On top of my head:

It's easier to scan the list if it's in alphabetical order, otherwise I have to scan up and down or use Find.

@elijah-potter
Copy link
Collaborator Author

Can they be enabled/disabled independently? Because some have become so entrenched that their users will probably want to keep using them:

Yup. They're standard rules.

@ccoVeille
Copy link
Contributor

If anyone has more suggestion, I would like to suggest to use to find them

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 6, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.18.1` -> `v0.19.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>Automattic/harper (Automattic/harper/harper-ls)</summary>

### [`v0.19.1`](https://github.com/Automattic/harper/releases/tag/v0.19.1)

[Compare Source](Automattic/harper@v0.18.1...v0.19.1)

#### What's Changed

The biggest change in this version: the ability to ignore lints. This is some pretty new code, so we hope to hear from you all to see how we can improve it.

-   feat: issue templates by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#539
-   feat(core): even more holidays by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#533
-   feat(core): implement "despite of" lint by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#531
-   feat(html): condense spaces like most HTML parsers by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#546
-   Ignore Lints by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#529
-   fix(core): [#&#8203;548](Automattic/harper#548) `you` is not a verb by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#551
-   docs: mention [#&#8203;536](Automattic/harper#536) on installation pages by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#538
-   Site fixes and updates by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#552
-   feat(core): created framework for correcting common phrases by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#550
-   feat(core): condense multi-token Latin words and phrases by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#473

**Full Changelog**: Automattic/harper@v0.18.1...v0.19.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjEuNiIsInVwZGF0ZWRJblZlciI6IjM5LjE2MS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants