-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): created framework for correcting common phrases #550
Conversation
On top of my head:
|
More:
Can they be enabled/disabled independently? Because some have become so entrenched that their users will probably want to keep using them:
|
It's easier to scan the list if it's in alphabetical order, otherwise I have to scan up and down or use Find. |
Yup. They're standard rules. |
If anyone has more suggestion, I would like to suggest to use to find them |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.18.1` -> `v0.19.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.19.1`](https://github.com/Automattic/harper/releases/tag/v0.19.1) [Compare Source](Automattic/harper@v0.18.1...v0.19.1) #### What's Changed The biggest change in this version: the ability to ignore lints. This is some pretty new code, so we hope to hear from you all to see how we can improve it. - feat: issue templates by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#539 - feat(core): even more holidays by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#533 - feat(core): implement "despite of" lint by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#531 - feat(html): condense spaces like most HTML parsers by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#546 - Ignore Lints by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#529 - fix(core): [#​548](Automattic/harper#548) `you` is not a verb by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#551 - docs: mention [#​536](Automattic/harper#536) on installation pages by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#538 - Site fixes and updates by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#552 - feat(core): created framework for correcting common phrases by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#550 - feat(core): condense multi-token Latin words and phrases by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#473 **Full Changelog**: Automattic/harper@v0.18.1...v0.19.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjEuNiIsInVwZGF0ZWRJblZlciI6IjM5LjE2MS42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
In the interest of #472 and #507, I've implemented a framework for correcting minor errors in common phrases. If anyone has any suggestions for more phrases that could in here, I'm all 👂s.
The current list is around line 70 of
phrase_corrections.rs
.