feat(#331): Literate Haskell Support #344

grantlemons · 2024-12-31T23:00:17Z

feat(Can I add language support to harper at runtime? #331): create literate haskell masker and parser
tests(Can I add language support to harper at runtime? #331): change tests to have spelling issues
tests(Can I add language support to harper at runtime? #331): create literate haskell masker unit tests
refactor(Can I add language support to harper at runtime? #331): simplify ident dict code

The parser does not support parsing the actual code beyond extracting identifiers, but I don't know how that would be implemented considering the vastly different contexts.
If we were able to, using CommentParser would be great. It is a little weird to have comments in your code when it's literate programming anyway, but I can see it happening.

Will need to be revisited before/after merging #302 because of the changes to the Parser and Masker traits.

elijah-potter

Looks and seems to work great! Mostly just looking for enhanced documentation. Why did you make the decisions you did?

harper-literate-haskell/Cargo.toml

harper-literate-haskell/src/masker.rs

elijah-potter · 2025-01-06T20:00:55Z

harper-ls/src/backend.rs

+                let source = text.chars().collect_vec();
+                let parser = LiterateHaskellParser;
+
+                if let Some(new_dict) = parser.create_ident_dict(&source) {


Could this be generalized to the other languages?

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.14.0` -> `v0.16.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.16.0`](https://github.com/Automattic/harper/releases/tag/v0.16.0) [Compare Source](Automattic/harper@v0.15.0...v0.16.0) #### What's Changed - [A false-positive for subordinating conjunctions was resolved](Automattic/harper#341). - [harper.js now properly reexports types from harper-wasm](Automattic/harper@aad7519). - [harper.js now has an automatically generated API reference page.](https://writewithharper.com/docs/harperjs/ref/harper.js.html) - [Some erroneous filtering of certain errors was creating false-negatives.](Automattic/harper#131) - [Words containing numbers are less likely to throw false-positive spelling errors.](Automattic/harper#195) - [A rule for variations of the word “your” was added](Automattic/harper@113bc36). - fix the nvim-lspconfig link by [@wadsaek](https://github.com/wadsaek) in Automattic/harper#367 - docs: added Scoop instructions by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#361 - Enable LTO and codegen-units = 1 in the Release profile by [@zamazan4ik](https://github.com/zamazan4ik) in Automattic/harper#363 - feat([#331](Automattic/harper#331)): Literate Haskell Support by [@grantlemons](https://github.com/grantlemons) in Automattic/harper#344 - build(deps): bump dirs from 5.0.1 to 6.0.0 by [@dependabot](https://github.com/dependabot) in Automattic/harper#372 - build(deps): bump tokio from 1.42.0 to 1.43.0 by [@dependabot](https://github.com/dependabot) in Automattic/harper#371 - build(deps): bump thiserror from 2.0.9 to 2.0.11 by [@dependabot](https://github.com/dependabot) in Automattic/harper#369 - feat: Typst Language Support by [@grantlemons](https://github.com/grantlemons) in Automattic/harper#302 - build(deps): bump serde_json from 1.0.134 to 1.0.135 by [@dependabot](https://github.com/dependabot) in Automattic/harper#368 - feat(core): create new linter for dollar sign placement by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#376 - refactor: Harper-ls Error-Handling Improvements by [@grantlemons](https://github.com/grantlemons) in Automattic/harper#349 - feat([#104](Automattic/harper#104)): Markdown linter config for ignoring link titles by [@grantlemons](https://github.com/grantlemons) in Automattic/harper#305 - feat(harper.js): added ability to configure the markup language by [@elijah-potter](https://github.com/elijah-potter) in Automattic/harper#379 - feat(vscode-plugin): Add Literate Haskell and Typst Support + some doc updates by [@mcecode](https://github.com/mcecode) in Automattic/harper#388 #### New Contributors - [@wadsaek](https://github.com/wadsaek) made their first contribution in Automattic/harper#367 - [@elijah-potter](https://github.com/elijah-potter) made their first contribution in Automattic/harper#361 - [@zamazan4ik](https://github.com/zamazan4ik) made their first contribution in Automattic/harper#363 **Full Changelog**: Automattic/harper@v0.15.0...v0.16.0 ### [`v0.15.0`](https://github.com/Automattic/harper/releases/tag/v0.15.0) [Compare Source](Automattic/harper@v0.14.0...v0.15.0) #### What's Changed - Added a variety of rules (see [complete list here](https://writewithharper.com/docs/rules)). - Fixed issues with parsing hostnames - Added a variety of available `Pattern`s for downstream use - Update +page.md by [@aminwhat](https://github.com/aminwhat) in Automattic/harper#347 - feat: Add technical words to dictionary by [@claydugo](https://github.com/claydugo) in Automattic/harper#343 - refactor: remove raw hashes that are unnecessary by [@hamirmahal](https://github.com/hamirmahal) in Automattic/harper#324 - feat: Span View Command Improvements by [@grantlemons](https://github.com/grantlemons) in Automattic/harper#340 - Address "one" for indefinite article rule by [@claydugo](https://github.com/claydugo) in Automattic/harper#359 - feat: Add support for cmake files by [@alcroito](https://github.com/alcroito) in Automattic/harper#353 - build(deps): bump itertools from 0.13.0 to 0.14.0 by [@dependabot](https://github.com/dependabot) in Automattic/harper#357 - feat(harper-ls): remove deleted file/s diagnostics by [@mcecode](https://github.com/mcecode) in Automattic/harper#304 - feat(vscode-plugin): Add CMake Support by [@mcecode](https://github.com/mcecode) in Automattic/harper#360 #### New Contributors - [@aminwhat](https://github.com/aminwhat) made their first contribution in Automattic/harper#347 - [@hamirmahal](https://github.com/hamirmahal) made their first contribution in Automattic/harper#324 - [@alcroito](https://github.com/alcroito) made their first contribution in Automattic/harper#353 **Full Changelog**: Automattic/harper@v0.14.0...v0.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

grantlemons added 6 commits December 31, 2024 16:31

feat(Automattic#331): create literate haskell masker and parser

fca1a9a

tests(Automattic#331): change tests to have spelling issues

1a8ed8d

tests(Automattic#331): create literate haskell masker unit tests

f8e6e77

refactor(Automattic#331): simplify ident dict code

50a7c14

Merge remote-tracking branch 'upstream/master' into literate-haskell

3f75fb0

Merge branch 'master' into literate-haskell

9ac2f2f

elijah-potter requested changes Jan 6, 2025

View reviewed changes

grantlemons and others added 4 commits January 6, 2025 13:08

fix: add crate info to Cargo.toml

15d00d5

feat: add doc comments to literate haskell structs

e3d7acf

Merge branch 'master' into literate-haskell

1266121

fix: hidden merge fallout

cd4aca5

elijah-potter merged commit a697b29 into Automattic:master Jan 10, 2025
17 checks passed

BrewTestBot mentioned this pull request Jan 15, 2025

harper 0.16.0 Homebrew/homebrew-core#204400

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(#331): Literate Haskell Support #344

feat(#331): Literate Haskell Support #344

grantlemons commented Dec 31, 2024 •

edited

Loading

elijah-potter left a comment

elijah-potter Jan 6, 2025

feat(#331): Literate Haskell Support #344

feat(#331): Literate Haskell Support #344

Conversation

grantlemons commented Dec 31, 2024 • edited Loading

elijah-potter left a comment

Choose a reason for hiding this comment

elijah-potter Jan 6, 2025

Choose a reason for hiding this comment

grantlemons commented Dec 31, 2024 •

edited

Loading