Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag "lets verb" and "let verb" #470

Open
ccoVeille opened this issue Jan 22, 2025 · 3 comments
Open

Flag "lets verb" and "let verb" #470

ccoVeille opened this issue Jan 22, 2025 · 3 comments
Labels

Comments

@ccoVeille
Copy link
Contributor

Following #426

I create a separate issue because while we agreed about "let's us" and all pronouns variations.

Something else emerged.

  • "lets play" this one is a typo, but we cannot say it's a double pronoun.

  • "let play" here the pronoun is missing

I think it should be distinct rules, because the way to report them is different

@hippietrail
Copy link
Contributor

I wouldn't classify the first as necessarily a typo, which means your fingers didn't do what your brain was thinking, since may people don't have a clear idea of why one has the apostrophe and the other doesn't. Sometimes it's a typo and sometimes it's not.

The second can be the product of two mistakes, omitting the verb or omitting the 's.

I haven't really looked into the linting engine yet but I wouldn't be surprised if things we think of as one mistake need several rules anyway. I might be wrong about that though.

@ccoVeille
Copy link
Contributor Author

My point was more to say the existing discussion around "let's pronoun" happened, and a PR is here.

Let's talk about other issues with "let"

I didn't want to bring confusion.

@hippietrail
Copy link
Contributor

I was just thinking about wording as it might end up in lint description fields sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants