Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows GitHub Actions builds missing dependency #208

Closed
elijah-potter opened this issue Oct 6, 2024 · 2 comments · Fixed by #217
Closed

Windows GitHub Actions builds missing dependency #208

elijah-potter opened this issue Oct 6, 2024 · 2 comments · Fixed by #217
Assignees
@elijah-potter
Labels
bug Something isn't working dependencies Pull requests that update a dependency file harper-ls visual-studio-code-plugin Related to the Harper Visual Studio Code integration

Comments

@elijah-potter
Copy link
Collaborator

Downloading the harper-ls binary for Windows and running it throws an error complaining about the absence of a libstdc++-6.dll file. Not sure how long this has been happening, but it's a major issue that needs to be dealt with before #200 can happen.
@elijah-potter elijah-potter added bug Something isn't working dependencies Pull requests that update a dependency file visual-studio-code-plugin Related to the Harper Visual Studio Code integration harper-ls labels Oct 6, 2024
@elijah-potter elijah-potter self-assigned this Oct 6, 2024
@elijah-potter elijah-potter mentioned this issue Oct 7, 2024
Merged
@mcecode
Copy link
Collaborator

mcecode commented Oct 8, 2024

So I got interested in this and experimented a bit. Seems like changing our build target on Windows from x86_64-pc-windows-gnu to x86_64-pc-windows-msvc fixes the problem, probably because MSVC is the default on Windows and is therefore more widely available.

Here's a sample run I did with an artifact you can try out: https://github.com/mcecode/harper/actions/runs/11242681556

@elijah-potter
Copy link
Collaborator Author

Would you mind opening a pull request to fix the Release job for this? Thanks for figuring that out.

mcecode added a commit to mcecode/harper that referenced this issue Oct 8, 2024
@mcecode
fix(Automattic#208): make windows build work
25ec640
mcecode added a commit to mcecode/harper that referenced this issue Oct 8, 2024
@mcecode
fix(Automattic#208): make windows build work
31c162b
@mcecode mcecode mentioned this issue Oct 8, 2024
Merged
elijah-potter pushed a commit that referenced this issue Oct 9, 2024
@mcecode @elijah-potter
fix(#208): make windows build work
4f0e7cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elijah-potter elijah-potter

Labels
bug Something isn't working dependencies Pull requests that update a dependency file harper-ls visual-studio-code-plugin Related to the Harper Visual Studio Code integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Windows GitHub Actions builds missing dependency mcecode/harper
2 participants
@elijah-potter @mcecode