Fix width calc w/ certain new ANSI escapes #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes width calculations that were off when table contained terminal hyperlink ANSI escape codes, which are some newer kind of ANSI escape codes, supported by some terminals, such as iTerm. This was accomplished by replacing regexes with use of the [strip-ansi](https://www.npmjs.com/package/strip-ansi) module, which presumably has more up-to-date regexes that know how to deal with these newer ANSI escape codes.
chrean
approved these changes
Nov 17, 2021
|
Solid contribution @msabramo ! Sorry for the late response, I am merging this. |
Closed
|
I believe this is the breaking change that caused #160. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes width calculations that were off when table contained terminal hyperlink ANSI escape codes, which are some newer kind of ANSI escape codes, supported by some terminals, such as iTerm.
This was accomplished by replacing regexes with use of the strip-ansi module, which presumably has more up-to-date regexes that know how to deal with these newer ANSI escape codes.
Fixes: #147