Add create-embed-test-post script and fix support for various embeds #829

westonruter · 2017-12-12T15:44:08Z

Fixes #806.

westonruter · 2017-12-12T15:45:07Z

bin/create-embed-test-post.php

+		'content' => function( $data ) {
+			return sprintf( '[gallery ids="%s"]', implode( ',', $data['ids'] ) );
+		},
+	),


This needs now to be fleshed out with all that can be thrown at content in a vanilla WordPress install.

kienstra · 2017-12-12T18:29:16Z

In Development

Hi @westonruter,
Thanks a lot for starting this. I'm working on this now if that's alright.

westonruter · 2017-12-12T18:29:58Z

Go for it!

westonruter · 2017-12-13T01:11:46Z

As time allows, we'll also want to do something similar for Gutenberg blocks.

Use Weston's wp-cli script to create a test post. Add media items to the post content. And add several embeds. Several embeds are still not rendering, Even on a standard, non-AMP page.

…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content

Before, the equals sign alignment caused a PHPCS warning. Fix this, to enable the Travis build to succeed.

create-embed-test-post.php needs to test all post content. As Weston mentioned, embedded posts are part of this.

kienstra · 2017-12-13T06:14:25Z

Request For Review
(For Issue #806)

Hi @ThierryA or @westonruter,
Could you please review my commits here, building on @westonruter's wp-cli file create-embed-test-post.php? To run it, simply cd to plugin's root, and run wp eval-file bin/create-embed-test-post.php.

This adds most of the allowed embeds to the post content. It also tests for other media types, as listed in Issue #806.

Also, @ThierryA's comment in #806 lists whether these newly-added embeds render properly in the AMP page.

There are some embeds that don't even render in the standard WordPress page, like Scribd and Photobucket.

If you'd like, I could work on Gutenberg block support tomorrow (Wednesday).

ThierryA

Thanks @kienstra and @westonruter, great work! I pushed this commit which does the following:

simplify code
remove PHP5.2 Travis exclude as it is no longer needed
add errors handling

Ready for your review and adjustments if need.

PS: this PR is approved from my perspective.

ThierryA · 2017-12-13T10:23:47Z

bin/create-embed-test-post.php

@@ -35,10 +209,63 @@ function amp_test_prepare_image_attachments( $data ) {
 	) );
 	$data['ids'] = wp_list_pluck( $attachments, 'ID' );

-	// @todo Add some attachments if count( $data['ids'] ) < 5.
+	$image_count_needed = 5;


I can't think of a case where this would be needed as a fallback rather than directly getting the images like we do for the other shortcodes (please advise if I am missing something). This commit simplifies this.

ThierryA · 2017-12-13T10:59:40Z

@kienstra @westonruter I think it would be great to document this script and steps to run it somewhere, whether it is in the contributing.md file and/or open an other issue (ex. "Support vanilla embeds") for the actual work AMP support work and refer to it in this PR description. Thoughs?

…oud shortcode * Hook into oEmbed filters for rewriting SoundCloud embeds as AMP components. * Ensure Jetpack is active while unit tests are run. * Explicitly install and activate Jetpack during unit tests. * Fix error message in create-embed-test-post.php * Fix phpcs for Soundcloud code.

…ntext

* Use noscript response from oEmbed as default content. * Include WPCOM_AMP_Polldaddy_Embed by default even when not on WordPress.com; deprecate wpcom/shortcodes.php. * Fix DailyMotion and FunnyOrDie test URLs. * Clean phpcs for class-amp-polldaddy-embed.php

westonruter · 2017-12-14T05:49:41Z

wpcom/class-amp-polldaddy-embed.php

+	 */
+	public function filter_embed_oembed_html( $cache, $url, $attr ) {
+		$parsed_url = wp_parse_url( $url );
+		if ( $url && false === strpos( $parsed_url['host'], 'polldaddy.com' ) ) {


This may need to include looking at poll.fm, but I've never seen any PollDaddy URLs look like that: https://github.com/WordPress/wordpress-develop/blob/c6326694380722ccbdd78e21a2bd0d079383291c/src/wp-includes/class-oembed.php#L69

While the risk is minimal, this could throw a PHP warning if the url passed doesn't have an host.

kienstra · 2017-12-14T06:35:30Z

Documenting wp-cli Script In contributing.md

Hi @ThierryA,

I think it would be great to document this script and steps to run it somewhere, whether it is in the contributing.md file and/or open an other issue...

That's a good idea. If it's alright, I'll add steps to use the wp-cli script in contributing.md.

Also, I need to add the oEmbed URLs that @westonruter requested.

ThierryA · 2017-12-14T09:45:48Z

bin/create-embed-test-post.php

+			'Please make sure at least %1$s "%2$s" attachments are accessible and run this script again.',
+			$image_count,
+			$type,
+			$posts_count


This can be removed now that the message changed.

Oh, I will restore it. I also realized we should use $query->found_posts and $query->post_count here.

ThierryA · 2017-12-14T09:46:32Z

includes/embeds/class-amp-soundcloud-embed.php

@@ -9,22 +9,49 @@
 * Class AMP_SoundCloud_Embed_Handler
 */
 class AMP_SoundCloud_Embed_Handler extends AMP_Base_Embed_Handler {


Adding the @since tag for new code and changes would be helpful.

ThierryA · 2017-12-14T09:49:01Z

includes/embeds/class-amp-soundcloud-embed.php

+	private function render_embed_fallback( $url ) {
+		return AMP_HTML_Utils::build_tag( 'a',
+			array(
+				'href' => esc_url( $url ),


I am not 100% sure why we excluded this rule. It is now inconsistent throughout the project which doesn't really make sense since we require the variable operators to be aligned.

PS: this is indeed not a blocker but I think it would be better to keep the code style as consistent as possible.

Yeah, I agree. I'll remove the WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned suppression.

ThierryA · 2017-12-14T10:06:07Z

tests/test-amp-soundcloud-embed.php

+		 * So on WP<4.9 we set a post global to ensure oEmbeds get processed.
+		 */
+		if ( version_compare( strtok( get_bloginfo( 'version' ), '-' ), '4.9', '<' ) ) {
+			$post = get_post( $this->factory()->post->create() );


Tips: get_post( $this->factory()->post->create() ) can be replaced with $this->factory()->post->create_and_get().

ThierryA · 2017-12-14T15:16:08Z

includes/embeds/class-amp-soundcloud-embed.php

+	 */
+	public function filter_embed_oembed_html( $cache, $url ) {
+		$parsed_url = wp_parse_url( $url );
+		if ( $url && false === strpos( $parsed_url['host'], 'soundcloud.com' ) ) {


While the risk is minimal, this could throw a PHP warning if the url passed doesn't have an host.

I don't believe this can ever happen.

ThierryA · 2017-12-14T15:36:37Z

wpcom/class-amp-polldaddy-embed.php

+	 */
+	public function filter_embed_oembed_html( $cache, $url, $attr ) {
+		$parsed_url = wp_parse_url( $url );
+		if ( $url && false === strpos( $parsed_url['host'], 'polldaddy.com' ) ) {


While the risk is minimal, this could throw a PHP warning if the url passed doesn't have an host.

ThierryA · 2017-12-14T15:37:42Z

That's a good idea. If it's alright, I'll make add steps to use the wp-cli script in contributing.md.

@kienstra sounds good to me.
@westonruter I added a round of CR, nothing major.

Add steps to contributing.md to use create-embed-test-post.php. Include a step that this should be inside an environment like VVV.

…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content

westonruter · 2017-12-14T18:08:01Z

I noticed that the iframe for Funny Or Die is getting stripped out, leaving behind just:

I Still Haven't Found the Droids I'm Looking For – watch more funny videos

We need to figure out why the AMP_Iframe_Sanitizer isn't applying here as expected.

@jsepia

Add these URLs to test oEmbed. Use the Amazon testing URLs in: https://core.trac.wordpress.org/ticket/38181 Props @jsepia for these URLs.

Use the URL from @wonderboymusic in: https://core.trac.wordpress.org/ticket/28379.

… into functions

* Add missing since tag * Update filter_embed_oembed_html calls since $url is required * Add DEFAULT_BASE_BRANCH=develop * Use create_and_get in test

…ame sanitizer has run Issue introduced in 575ac66

Thanks to ohthenoes for the Photobucket link in: https://core.trac.wordpress.org/ticket/13754 And thanks to @wonderboymusic for the Scribd URL from: https://core.trac.wordpress.org/ticket/28379.

The only conflict was from array alignment. It was a whitespace-only edit.

Add a Screencast embed, thanks to designsimply's URL in: https://core.trac.wordpress.org/ticket/24660 Because Vine isn't supported anymore, remove its test URL. @see wordpress-develop/src/wp-includes/class-oembed.php

Both the full URL, and the short URL ending with the TLD .ly. They both render well in AMP.

kienstra · 2017-12-14T20:15:42Z

Tests For All oEmbed Providers

Hi @westonruter,
Thanks for your patience. There are now tests for all WordPress oEmbed providers in create-embed-test-post.php.

Still, some of them aren't rendering properly, even on a non-AMP page. Including Imgur, Photobucket, and Screencast. I'm working on those now.

Change the URLs for most of these. And remove the soundcloud shortcode. This isn't supported natively.

…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content

Use mrdenn1s's image from his Trac ticket: https://core.trac.wordpress.org/ticket/28345 It looks like Imgur oEmbeds no longer work in WordPress. @see https://core.trac.wordpress.org/ticket/42247

kienstra · 2017-12-14T23:12:55Z

Tests For Almost All oEmbeds

Hi @westonruter,
This now has tests for almost all oEmbeds. Except for Imgur, which seems to not be supported.

Add skeleton for create-embed-test-post script

a6fda64

westonruter commented Dec 12, 2017

View reviewed changes

kienstra self-assigned this Dec 12, 2017

Fix syntax of PATH_EXCLUDES_PATTERN and add PHPCS exclude-pattern

6ef9768

Ryan Kienstra added 4 commits December 12, 2017 19:49

Issue 806 : Add media and embeds to test page.

550ed65

Use Weston's wp-cli script to create a test post. Add media items to the post content. And add several embeds. Several embeds are still not rendering, Even on a standard, non-AMP page.

Merge branch 'add/806-add-script-for-testing-content' of https://gith…

369696b

…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content

Issue 806 : Align equals signs vertically.

7c77752

Before, the equals sign alignment caused a PHPCS warning. Fix this, to enable the Travis build to succeed.

Issue 804 : Test WordPress post embeds.

128836c

create-embed-test-post.php needs to test all post content. As Weston mentioned, embedded posts are part of this.

kienstra mentioned this pull request Dec 13, 2017

Build out list of all vanilla WordPress “blocks” and their AMP compatibility #806

Closed

kienstra requested a review from ThierryA December 13, 2017 06:18

kienstra assigned ThierryA and unassigned kienstra Dec 13, 2017

kienstra changed the title ~~[WIP] Add skeleton for create-embed-test-post script~~ Add skeleton for create-embed-test-post script Dec 13, 2017

kienstra changed the title ~~Add skeleton for create-embed-test-post script~~ Issue 806 : Add skeleton for create-embed-test-post script Dec 13, 2017

Issue 806 : code improvement

b8ba836

ThierryA approved these changes Dec 13, 2017

View reviewed changes

westonruter mentioned this pull request Dec 14, 2017

Add support for amp-soundcloud #640

Merged

amedina changed the title ~~Issue 806 : Add skeleton for create-embed-test-post script~~ Add skeleton for create-embed-test-post script Dec 14, 2017

westonruter added 2 commits December 13, 2017 20:07

Fix phpunit tests in WP<4.9 due to oEmbeds formerly requiring post co…

938be72

…ntext

westonruter changed the title ~~Add skeleton for create-embed-test-post script~~ Add create-embed-test-post script and fix support for various embeds Dec 14, 2017

westonruter commented Dec 14, 2017

View reviewed changes

ThierryA reviewed Dec 14, 2017

View reviewed changes

Ryan Kienstra added 2 commits December 14, 2017 11:43

Issue 806 : Add instructions for using the wp-cli test page script.

52b306b

Add steps to contributing.md to use create-embed-test-post.php. Include a step that this should be inside an environment like VVV.

Merge branch 'add/806-add-script-for-testing-content' of https://gith…

13132ed

…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content

Ryan Kienstra and others added 10 commits December 14, 2017 12:34

Issue 804 : Add Amazon, Animoto, and Speakerdeck URLs

eaf5157

Add these URLs to test oEmbed. Use the Amazon testing URLs in: https://core.trac.wordpress.org/ticket/38181 Props @jsepia for these URLs.

Issue 804 : Update the Scribd URL.

8e34745

Use the URL from @wonderboymusic in: https://core.trac.wordpress.org/ticket/28379.

Restore required attachment count in create-embed-test-post; refactor…

b22e12a

… into functions

Remove DoubleArrowNotAligned PHPCS suppression

f1ee3de

* Add missing since tag * Update filter_embed_oembed_html calls since $url is required * Add DEFAULT_BASE_BRANCH=develop * Use create_and_get in test

Fix order of sanitizers to ensure whitelist applies at end, after ifr…

a91d7ad

…ame sanitizer has run Issue introduced in 575ac66

Issue 806 : Update the Photobucket and Scribd URLs.

499e580

Thanks to ohthenoes for the Photobucket link in: https://core.trac.wordpress.org/ticket/13754 And thanks to @wonderboymusic for the Scribd URL from: https://core.trac.wordpress.org/ticket/28379.

Issue 806 : Merge in feature branch, resolve conflicts.

6309f41

The only conflict was from array alignment. It was a whitespace-only edit.

Issue 806 : Remove Vine embed, add Screencast embed.

d2dd032

Add a Screencast embed, thanks to designsimply's URL in: https://core.trac.wordpress.org/ticket/24660 Because Vine isn't supported anymore, remove its test URL. @see wordpress-develop/src/wp-includes/class-oembed.php

Issue 806 : Add tests for Someecards.

8732936

Both the full URL, and the short URL ending with the TLD .ly. They both render well in AMP.

Fix phpcs issues in class-amp-rule-spec.php

5bce94f

Ryan Kienstra added 3 commits December 14, 2017 16:33

Issue 806 : Correct embeds, including Imgur, Polldaddy, Screencast.

e885b7a

Change the URLs for most of these. And remove the soundcloud shortcode. This isn't supported natively.

Merge branch 'add/806-add-script-for-testing-content' of https://gith…

a485be1

…ub.com/Automattic/amp-wp into add/806-add-script-for-testing-content

Issue 806 : Update Photobucket, Tumblr, remove Imgur.

ed6088d

Use mrdenn1s's image from his Trac ticket: https://core.trac.wordpress.org/ticket/28345 It looks like Imgur oEmbeds no longer work in WordPress. @see https://core.trac.wordpress.org/ticket/42247

westonruter added this to the v0.6 milestone Dec 14, 2017

westonruter merged commit 78c60fa into develop Dec 14, 2017

westonruter deleted the add/806-add-script-for-testing-content branch February 3, 2018 19:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add create-embed-test-post script and fix support for various embeds #829

Add create-embed-test-post script and fix support for various embeds #829

westonruter commented Dec 12, 2017

westonruter Dec 12, 2017

kienstra commented Dec 12, 2017

westonruter commented Dec 12, 2017

westonruter commented Dec 13, 2017

kienstra commented Dec 13, 2017 •

edited

Loading

ThierryA left a comment •

edited

Loading

ThierryA Dec 13, 2017

ThierryA commented Dec 13, 2017 •

edited

Loading

westonruter Dec 14, 2017

ThierryA Dec 14, 2017

kienstra commented Dec 14, 2017 •

edited

Loading

ThierryA Dec 14, 2017

westonruter Dec 14, 2017

ThierryA Dec 14, 2017

ThierryA Dec 14, 2017 •

edited

Loading

westonruter Dec 14, 2017

ThierryA Dec 14, 2017

ThierryA Dec 14, 2017

westonruter Dec 14, 2017

ThierryA Dec 14, 2017

ThierryA commented Dec 14, 2017 •

edited

Loading

westonruter commented Dec 14, 2017

kienstra commented Dec 14, 2017

kienstra commented Dec 14, 2017

Add create-embed-test-post script and fix support for various embeds #829

Add create-embed-test-post script and fix support for various embeds #829

Conversation

westonruter commented Dec 12, 2017

Choose a reason for hiding this comment

kienstra commented Dec 12, 2017

westonruter commented Dec 12, 2017

westonruter commented Dec 13, 2017

kienstra commented Dec 13, 2017 • edited Loading

ThierryA left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ThierryA commented Dec 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kienstra commented Dec 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ThierryA Dec 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ThierryA commented Dec 14, 2017 • edited Loading

westonruter commented Dec 14, 2017

kienstra commented Dec 14, 2017

kienstra commented Dec 14, 2017

kienstra commented Dec 13, 2017 •

edited

Loading

ThierryA left a comment •

edited

Loading

ThierryA commented Dec 13, 2017 •

edited

Loading

kienstra commented Dec 14, 2017 •

edited

Loading

ThierryA Dec 14, 2017 •

edited

Loading

ThierryA commented Dec 14, 2017 •

edited

Loading