Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let amp-carousel be optional for galleries #1065

Closed
RitaRoca opened this issue Apr 7, 2018 · 4 comments
Closed

Let amp-carousel be optional for galleries #1065

RitaRoca opened this issue Apr 7, 2018 · 4 comments
Labels
Milestone

Comments

@RitaRoca
Copy link

RitaRoca commented Apr 7, 2018

Hi, I see that the plugin converts automatically a Wordpress Gallery into a slider. Can I disable that option to get the normal gallery?

Thanks

@westonruter
Copy link
Member

This is something I've noticed that I think needs to change. The gallery output in AMP should be the same as the normal gallery, with opt-in for enhancements such as carousel. Maybe lightbox could be included by default. We can take cues from Jetpack's gallery extensions here.

@westonruter westonruter added this to the v1.0 milestone Apr 18, 2018
@westonruter westonruter changed the title Carrousel WP Galley Let amp-carousel be optional for galleries Apr 18, 2018
@miina miina assigned miina and unassigned miina Apr 26, 2018
@postphotos
Copy link
Contributor

Thanks @RitaRoca - We have this in our backlog as an item to work on and I believe we'll find a decent alternative here. 👍

Reminds me of Should I use a carousel and Yoast's summary on sliders.

@westonruter
Copy link
Member

Fixed in #1121

@kienstra
Copy link
Contributor

kienstra commented Jun 5, 2018

Moving To "Ready For Merging"

The test steps in #1121 should cover this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants