MAYA-106486 UDIM Import/Export #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly detect and handle UDIM on import and export.
mattyjams
approved these changes
Nov 3, 2020
Comment on lines
+211
to
+229
| // USD did not resolve the path to absolute because the file name was not an | ||
| // actual file on disk. We need to find the first tile to help Maya find the | ||
| // other ones. | ||
| std::string udimPath(filePath.substr(0, udimPos)); | ||
| udimPath += "1001"; | ||
| udimPath += filePath.substr(udimPos + _tokens->UDIMTag.GetString().size()); | ||
|
|
||
| Usd_Resolver res(&prim.GetPrimIndex()); | ||
| for (; res.IsValid(); res.NextLayer()) { | ||
| std::string resolvedName | ||
| = SdfComputeAssetPathRelativeToLayer(res.GetLayer(), udimPath); | ||
|
|
||
| if (!resolvedName.empty() && !ArIsPackageRelativePath(resolvedName) | ||
| && resolvedName != udimPath) { | ||
| udimPath = resolvedName; | ||
| break; | ||
| } | ||
| } | ||
| val = SdfAssetPath(udimPath); |
There was a problem hiding this comment.
As of USD 20.08, there's a UsdImaging_ResolveMaterialParamValue() utility that might be useful here:
https://github.com/PixarAnimationStudios/USD/blob/71b4baace2044ea4400ba802e91667f9ebe342f0/pxr/usdImaging/usdImaging/materialParamUtils.h#L45
There was a problem hiding this comment.
Would love to use that function, but it is currently private:
https://github.com/PixarAnimationStudios/USD/blob/dev/pxr/usdImaging/usdImaging/CMakeLists.txt#L68
Maybe in the next version?
JGamache-autodesk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly detect and handle UDIM on import and export.