migrate remaining relevant pxrUsdTranslators tests to test/lib/usd/translators #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test previously exercised plugin loading of the pxrUsdTranslators plugin, which now no longer exists. This test wasn't currently being registered or run anyway.
The pxrUsdTranslators plugin no longer exists, so this test wasn't actually testing anything.
…portStroke This test exercises one of the translators built into mayaUsd for exporting 'stroke' Maya nodes to USD.
…rtScope This test exercises one of the translators built into mayaUsd for importing and exporting Maya nodes as UsdGeomScope prims.
…xportMayaInstancer This test exercises one of the translators built into mayaUsd for Maya instancers as UsdGeomPointInstancer prims. This was the final test remaining in the now defunct pxrUsdTranslators plugin, so that directory in the Pixar plugin can also be removed.
Besides removing references to the now non-existent pxrUsdTranslators plugin, this also adjusts some of the language in the Pixar plugin documentation to suggest favoring the mayaUsd library and the mayaUsdPlugin over pxrUsd.
HamedSabri-adsk
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pxrUsdTranslatorsplugin is no more, but a few of the tests that live there exercise translators that are now in core mayaUsd, so these changes move/rename those tests into thetest/lib/usd/translatorsarea.The
testPxrUsdTranslatorsandtestPxrUsdTranslatorsUnloadReloadtests were fully useless following the removal of thepxrUsdTranslatorsplugin, and in facttestPxrUsdTranslatorsUnloadReloadwasn't even being registered, so those tests were simply deleted.I also touched up a few bits of documentation in the Pixar plugin to remove references to
pxrUsdTranslatorsand also subtly suggest that people consider usingmayaUsdPlugininstead ofpxrUsd.