Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix opacity vs. transparency issues with UsdPreviewSurface and pxrUsdPreviewSurface #626

Merged
merged 3 commits into from
Jul 7, 2020
Merged

fix opacity vs. transparency issues with UsdPreviewSurface and pxrUsdPreviewSurface #626

merged 3 commits into from
Jul 7, 2020

Conversation

mattyjams
Copy link
Contributor

These changes should address #607 which saw a breakage in the handling of the opacity control on pxrUsdPreviewSurface. They were written according to @HdC-adsk's proposal in that issue.

@mattyjams
add a UsdPreviewSurfaceCore fragment graph that accepts transparency …
fe0f392 
…instead of opacity

This fragment graph is a duplicate of the original UsdPreviewSurface graph with
one modification to have it take a "transparency" value instead of an "opacity"
value.

Subsequent changes will modify the original UsdPreviewSurface fragment graph to
forward nearly all of its connections to this new core, and to make the shading
node override for pxrUsdPreviewSurface use the core directly, since it converts
"opacity" to "transparency" itself.
@mattyjams
rewire UsdPreviewSurface to take advantage of the new UsdPreviewSurfa…
5b971ff 
…ceCore
@mattyjams
use UsdPreviewSurfaceCore in the shading node override for pxrUsdPrev…
22f0623 
…iewSurface

The shading node does its own conversion of "opacity" to "transparency" in its
compute() function, so we make its override use the core directly.
@mattyjams mattyjams mentioned this pull request Jul 7, 2020
Closed
@kxl-adsk kxl-adsk added core Related to core library vp2renderdelegate Related to VP2RenderDelegate labels Jul 7, 2020
huidong-chen
huidong-chen approved these changes Jul 7, 2020
View reviewed changes
Copy link

@huidong-chen huidong-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it.

@huidong-chen huidong-chen added the import-export Related to Import and/or Export label Jul 7, 2020
@kxl-adsk kxl-adsk merged commit 1c0de92 into Autodesk:dev Jul 7, 2020
@mattyjams mattyjams deleted the pr/UsdPreviewSurface_fragment_graph_opacity_vs_transparency branch July 7, 2020 16:19
huidong-chen pushed a commit that referenced this pull request Nov 6, 2020
Revert "Merge pull request #626 from mattyjams/pr/UsdPreviewSurface_f…
a27a8e4 
…ragment_graph_opacity_vs_transparency"

This reverts commit 1c0de92, reversing
changes made to 7454da1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huidong-chen huidong-chen huidong-chen approved these changes

Assignees
No one assigned
Labels
core Related to core library import-export Related to Import and/or Export vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattyjams @huidong-chen @kxl-adsk