MAYA-105123 wait for build to start, then wait for completion and pos… #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithw-adsk
added
the
do-not-merge-yet
kxl-adsk
suggested changes
Jun 17, 2020
| # Wait for remote build to start | ||
| - name: Wait until remote build starts | ||
| shell: bash | ||
| # 1080 = 180 minutes in 10 second increments. There will be overhead for the git pull command, so wait time will be more than 180 minutes |
There was a problem hiding this comment.
From the end-user perspective, I don't really care if this sleep will be 10 seconds or 1 minute. How about we reduce the frequency of these calls?
BTW. Typically we count the time that is elapsed, not the number of iterations. Is this something hard to achieve here?
There was a problem hiding this comment.
That's a good idea. 1-minute sleeps is vastly more intuitive. I'll add that now.
We could be more precise with the timing, but I think the rough count is sufficient for the timeout purpose.
seando-adsk
approved these changes
Jun 17, 2020
kxl-adsk
approved these changes
Jun 18, 2020
kxl-adsk
removed
the
do-not-merge-yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t results