Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[al] Removed tracking selectability and lock metadata #2075

Conversation

csyshing
Copy link
Collaborator

@csyshing csyshing commented Feb 8, 2022

Previously, AL_USDMaya tracks selectability and locking metadata, but there are few issues for this approach:

  • selectability / locking status are easily becoming out of sync when user toggling the optionVar (from Maya menu);
  • setting selectability and locking metadata can affect each other
  • changes received from UsdTransation does not carry detail information about if metadata has been touched (see ProxyShape::onTransactionNotice()), thus also making the status out of sync easily

This PR is meant to change the logic to be "query selectability / locking when needed", it is the most straightforward and accurate way to track selectability and locking.

Notice that this PR affects the "transform chain" (parent transforms that are created automatically when selecting geometry prims, or for those prims that have been marked as "importByDefault" and "needsTransformParent" in schema translators or Python translators) regardless of the viewport mode.

@csyshing csyshing added the al Related to AnimalLogic plugin label Feb 8, 2022
Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FWIW. I wonder if you had a chance to check what was done for selectability and attribute locking in base proxy shape?

@csyshing
Copy link
Collaborator Author

csyshing commented Feb 8, 2022

I wonder if you had a chance to check what was done for selectability and attribute locking in base proxy shape?

Yes @kxl-adsk , we are transitioning to use the features provided from the base class, instead of relying on AL_USDMaya. This PR is just yet another one to align internal and external code base.

@kxl-adsk kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 9, 2022
@seando-adsk seando-adsk merged commit f41faf9 into Autodesk:dev Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
al Related to AnimalLogic plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants