Use the quaternion type directly rather than interpreting the values of a vec4. #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamkrick
commented
Dec 14, 2021
| @@ -178,10 +178,10 @@ VtMatrix4dArray HdVP2Instancer::ComputeInstanceTransforms(SdfPath const& prototy | |||
| if (_primvarMap.count(_tokens->rotate) > 0) { | |||
| HdVP2BufferSampler sampler(*_primvarMap[_tokens->rotate]); | |||
| for (size_t i = 0; i < instanceIndices.size(); ++i) { | |||
| GfVec4h quath; | |||
| GfQuath quath; | |||
There was a problem hiding this comment.
We could guard the two different branches here using a PXR_VERSION preprocessor macro, but the code as is will work correctly in 21.11 and older versions.
seando-adsk
approved these changes
Dec 14, 2021
williamkrick
added
the
ready-for-merge
seando-adsk
deleted the
krickw/MAYA-120718/handle_quaternion_value_order_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.