Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing lighting issues with UsdPreviewSurface #1682

Merged
merged 1 commit into from
Sep 7, 2021

Commits on Sep 3, 2021

  1. Fixing lighting issues with UsdPreviewSurface

    We recently debugged a scene that failed to render correctly with the V2
    Light API. The main issue with shadows was fixed in another PR, but there
    were still 3 other problems where the Light API V1 was not on-par with USD
    and the V2 Light API.
    
    1- Directional light affects IBL lighting
    
    Create a test scene:
    
    - 20x20 plane at the origin, usdPreviewSurface shading, 50% metalness
    - aiSkyDomeLight with an environment map
    - Directional light with *zero* intensity
    
    Rotate the directional light, and watch how it affects the lighting of the plane. That light has zero intensity, so it should have no effect.
    
    2- textured occlusion does not affect environment lighting
    
    One of the assets in the scene had a textured occlusion map which
    correctly worked with scene lights, but not with aiSkyDome lights.
    
    3- specular highlights from regular Maya lights did not have enough base
    color for metallic workflows.
    
    That one was fixed for aiSkyDome lights in PR #1356 but direct lighting
    still used the old formula.
    JGamache-autodesk committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    f4a7f05 View commit details
    Browse the repository at this point in the history