MAYA-111932 no USD prompt during crash #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Jul 26, 2021
pierrebai-adsk
commented
- Detect if the Maya SDK supports the new crash check function.
- If present, use it to determine if Maya is crashing during auto-save.
- If Maya is crashing, avoid asking the user and just save the USD data inside the Maya recovery file.
- Detect if the Maya SDk support the new crash check function. - If present, use it to determine if Maya is crashing durin g auto-save. - If Maya is crashing, avoid asking the user and just save USD data inside the Maya recovery file.
pierrebai-adsk
added
ready-for-merge
ppt-adsk
reviewed
Jul 27, 2021
lib/mayaUsd/nodes/layerManager.cpp
Outdated
| if (_batchSaveDelegate && _proxiesToSave.length() > 0) { | ||
| if (isCrashing()) { | ||
| result = kPartiallyCompleted; | ||
| opt = MayaUsd::utils::kSaveToUSDFiles; |
There was a problem hiding this comment.
Your pull request description says you'll save inside the Maya file when crashing, but your code says save to USD files. Which one should it be?
There was a problem hiding this comment.
Is Maya, thanks for catching this.
ppt-adsk
approved these changes
Jul 27, 2021
pierrebai-adsk
added
the
ready-for-merge
|
@pierrebai-adsk We merged a number of changes. Please resolve merge conflicts and run PF. |
pierrebai-adsk
removed
the
ready-for-merge
pierrebai-adsk
added
ready-for-merge
|
I'll be honest, I don't understand why clang-format made me reformat MenuBuilder.cpp. It seems to me the line was shorter than 100 columns limit...? |
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.