Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib namespace cleanup part 0 of n. #1214

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

ppt-adsk
Copy link
Collaborator

@ppt-adsk ppt-adsk commented Feb 25, 2021

PXR_NAMESPACE_USING_DIRECTIVE in headers pollutes the namespace with Pixar namespace symbols, and PXR_NAMESPACE_OPEN_SCOPE places mayaUsd symbols in the Pixar namespace, both of which are undesirable. This is because of the mayaUsd's origins in the Pixar plugin code base, which needs to be cleaned up. This pull request is the first of many to implement this cleanup.

Copy link
Contributor

@HamedSabri-adsk HamedSabri-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for part 00. Thanks.

@ppt-adsk ppt-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 26, 2021
@kxl-adsk
Copy link

@ppt-adsk please improve the title and description of this PR.

@kxl-adsk kxl-adsk added the build Related to building maya-usd repository label Feb 26, 2021
@kxl-adsk kxl-adsk merged commit b656585 into dev Feb 26, 2021
@kxl-adsk kxl-adsk deleted the tremblp/MAYA-110153/fix_pxr_namespace_00 branch February 26, 2021 11:39
@ppt-adsk ppt-adsk changed the title Tremblp/maya 110153/fix pxr namespace 00 lib namespace cleanup part 0 of n. Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants