MAYA-109927: Remove dependency on boost::hash_combine. #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamedSabri-adsk
changed the title
HamedSabri-adsk
added
the
ready-for-merge
kxl-adsk
approved these changes
Feb 23, 2021
| @@ -221,14 +221,15 @@ Respect the minimum supported version for Maya and USD stated in [build.md](http | |||
| Recent extensions to the C++ standard introduce many features previously only found in [boost](http://boost.org). To avoid introducing additional dependencies, developers should strive to use functionality in the C++ std over boost. If you encounter usage of boost in the code, consider converting this to the equivalent std mechanism. | |||
| Our library currently has the following boost dependencies: | |||
| * `boost::python` | |||
| * `boost::hash_combine` (see [this proposal](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0814r0.pdf) ) | |||
| * `boost::make_shared` (preferable to replace with `std::shared_ptr`) | |||
|
|
|||
| ***Update:*** | |||
There was a problem hiding this comment.
In the last PR, it would be good to clean-up this Update section, since we people can use GitHub to check the history of changes. We don't need to keep them in the document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on boost::hash_combine.
MayaUsd::hash_combineshould be used instead across the project