Fix incorrect bindTransforms being determined during export
#1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oes not have a populated bindPose attribute
ysiewappl
force-pushed
the
bindtransform-export-bug
branch
from
0b2939b
to
4290b3c
Compare
|
@ysiewappl Thank you for another great contribution. Just wanted to let you know that on Autodesk side we have an extended holiday break, returning in January. Have a wonderful holiday season! |
kxl-adsk
reviewed
Dec 22, 2020
kxl-adsk
reviewed
Dec 22, 2020
kxl-adsk
approved these changes
Dec 22, 2020
kxl-adsk
added
import-export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi:
This PR fixes an issue that was noticed while I was working on #1016, where: under the situation where a joint does not have its
bindPoseattribute populated with a correct bind transform matrix, the resulting exported USD is incorrect (object has an offset that appears different to what is represented in Maya). This is because the exporter assumes a default identity matrix if it cannot find data on the plug to use.An example of this problem is shown below, where you can see that the offending bind transform was assumed to be an identity matrix by the exporter (both spheres should have the same Y-value):
Please review and raise any concerns.