OGSMOD-8158 - Hot Fix - Fix unit tests on macOS #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
laforel
approved these changes
Oct 15, 2025
DDoS
approved these changes
Oct 15, 2025
Signed-off-by: Patrick Hodoul <[email protected]>
DDoS
reviewed
Oct 15, 2025
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
DDoS
reviewed
Oct 16, 2025
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
DDoS
reviewed
Oct 16, 2025
CMakeLists.txt
Outdated
|
|
||
| # Set platform-specific install RPATH. | ||
| if (APPLE) | ||
| set(_RPATH "@loader_path;@loader_path/../lib") |
There was a problem hiding this comment.
Assuming we need to find libraries in lib/ from either lib/ or bin/, then @loader_path/../lib is all you need: lib/../lib -> lib, bin/../lib -> lib.
There was a problem hiding this comment.
The idea was to be generic in case 'someone' installs the libraries in bin.
There was a problem hiding this comment.
You're really not supposed to do that on POSIX, but OK.
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request fixes the unit tests on macOS by correctly updating the
RPATH.Note: Tested with
NinjaandXCodeon macOS andNinjaon Linux.