Fixes #20: adds a spinner during graph load #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e issuing async net request, stops (and destroys) the spinner once request is complete.
larsxschneider
approved these changes
Dec 13, 2017
| @@ -115,10 +115,18 @@ var stackedBarChartDefaults = | |||
| maintainAspectRatio: false | |||
| }; | |||
|
|
|||
| function createSpinner(canvas) | |||
| { | |||
| var parent = $("<div style=\"position:absolute;height:100%;width:100%;\"></div>"); | |||
There was a problem hiding this comment.
Here and in the other places below I think we should rather use let to declare the variables, no? I know this is not yet consistent throughout the codebase (... and that's why I love you linting proposal).
Does this sound good to you? If yes, then you don't need to to anything. I would just adjust your commit on merge.
There was a problem hiding this comment.
Sounds fine to me! Whatever style the project decides on, I will conform to. 👍
Once I start putting together the JS test running and linting changes I have planned, we can discuss in finer detail the particular JS style rules the project wants to adopt.
|
Merged via ada9a07 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #20: display a loading indicator while Hubble is off fetching data.
Changes
a) create a spinner
b) hide the spinner once network request completes
Considerations
Testing It
I pointed the
_config.ymlfile tohttp://localhost:4000/demo-data, then ranjekyll servefrom thedocs/folder. I loaded up http://localhost:4000 in Chrome, and using the Chrome Developer Tools' Network tab, I set the simulated network speed to "Slow 3G", then refreshed the page. That network profile was slow enough for me to be able to ensure that the spinner does show up relatively centered over where incoming graphs will be rendered to.