-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Because of a mistake, the end date of time ranges as shown in the dashboard was not copied by value but by reference. As an effect, displayed dates would be repeatedly decremented by one second every time users hovered data points. For this reason, displayed dates could vary when hovering them multiple times. This is easily fixed by copying the affected variable by value. Multiple test cases ensure that no off-by-one errors or local time zone issues occur.
- Loading branch information
1 parent
7eceacd
commit 9366cee
Showing
4 changed files
with
83 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,8 @@ | |
"jquery": true | ||
}, | ||
"globals": { | ||
"d3": false | ||
"d3": false, | ||
"moment": false, | ||
"Date": false | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters