Improve authoring of quad and mesh lights #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
When a shader connection exists in an arnold light and is written to USD, we now author a ArnoldNodeGraph primitive that allows the connection to be taken into account in Hydra.
Also, we no longer author GeometryLight primitives which are deprecated. Instead we add a tag in the mesh
primvars:arnold:lightand author the light attributes in the mesh with this same namespace.These changes allows to enable test_0053, test_0076 and test_0111 in hydra mode
Issues fixed in this pull request
Fixes #1955