Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert type #10

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

convert type #10

wants to merge 40 commits into from

Conversation

Sedighe-Raeisi
Copy link

Description

Provide a high-level summary of the change and which issue it relates to.
Include relevant motivation and context.

If the issue is on Github, simply link to it using the '#' symbol):

  • resolves #(issue)

Type of change

Delete as appropriate:

  • fix: A bug fix
  • feat: A new feature
  • refactor: A code change that neither fixes a bug nor adds a feature
  • docs: Documentation only changes
  • test: Adding missing tests or correcting existing tests
  • perf: A code change that improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • ci: Changes to our CI configuration files and scripts (i.e., those in the .github directory)
  • build: Changes that affect the build system or external dependencies (i.e., poetry, conda)

If this is a breaking change (which might apply to any of the other kinds of change), note that below, otherwise delete
this section:

  • BREAKING_CHANGE: {description}

Update the title of the PR to follow the convention:
{type}{! if BREAKING_CHANGE}: {short description}, e.g.

  • "fix: add missing foo in module bar"
  • "feat: new theorist abc",
  • "feat!: replace module x with module y"
  • "docs: add notebooks on theorist z"

... then delete this block.

Features (Optional)

  • bulleted list of features, describing the code contributions in this pull request

Questions (Optional)

  • potential questions for the code reviewer (e.g., if you want feedback on a certain method or class; any feedback required from other code contributors with their mentioning)

Remarks (Optional)

  • any additional remarks for the code reviewer
  • if your remarks or questions pertain to individual lines in the code, you may also include them as comments in the code review window

Screenshots (Optional)

If your PR is related to UI change or anything visual, feel free to include screenshots to give the reviewer straightforward understandings on your changes.

Anish-Hs and others added 30 commits July 29, 2024 11:32
I fixed the issue #5  and #3
Division by zero is excluded #5
I add a print line that says b can't be zero
I moved the print into the condition block
Updating return_random_number
I resolved the conflict with rand region
add a space before b
Update from Sedighe branch utils.py
I added the seed into rand function
I created a test using try-except for the function return_random_number.
seed added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants