Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(controller): 4 - put together the components for the upgraded AER Controller #305

Closed

Conversation

hollandjg
Copy link
Member

@hollandjg hollandjg commented Mar 22, 2023

Description

Create new Controllers which supersede the SimpleCycle.

This is part of the solution to:

This builds on:

Todos:

  • Convert __init__.py into a notebook and include in documentation. Can we still use it as doctests?

Type of change:

  • New feature (non-breaking change which adds functionality)

Features:

... c.data.theories[-2].coef_.item()) > 1e-3,
... cycle
... )
... )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat!

Copy link
Collaborator

@musslick musslick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fantastic. Especially the ability to define your own planner and introduce contingencies about which experimentalist/theorist to use dependent on the history object.

The examples in the init are really well documented and this makes we wonder whether we could supply a python notebook here that we could easily integrate in the documentation (or on Google Collab)? I think this would help users a lot. We could literally use the init.py examples as the notebook. What do you think?


However, if we seed the same cycle with observations, then its first Executor will be the
theorist:
>>> controller_with_seed_observation = Controller(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@hollandjg
Copy link
Member Author

I think this looks fantastic. Especially the ability to define your own planner and introduce contingencies about which experimentalist/theorist to use dependent on the history object.

The examples in the init are really well documented and this makes we wonder whether we could supply a python notebook here that we could easily integrate in the documentation (or on Google Collab)? I think this would help users a lot. We could literally use the init.py examples as the notebook. What do you think?

Yes, we totally should. I'm not yet sure the best way to do that and integrate the notebook with the documentation though.

@hollandjg hollandjg marked this pull request as ready for review March 28, 2023 15:07
@hollandjg hollandjg linked an issue Mar 31, 2023 that may be closed by this pull request
@hollandjg hollandjg changed the title feature: put together the components for the upgraded AER Controller feature(controller): 4 - put together the components for the upgraded AER Controller Apr 6, 2023
@hollandjg
Copy link
Member Author

this is too big. Closing for now, will move this to a separate repo. Thanks for the feedback!

@hollandjg hollandjg closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improve seeding interface for Cycle
2 participants