Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

refactor: rename from observations.dvs/ivs to data.conditions/observations #15

Merged
merged 19 commits into from
Jul 6, 2023
Merged

refactor: rename from observations.dvs/ivs to data.conditions/observations #15

merged 19 commits into from
Jul 6, 2023

Conversation

hollandjg
Copy link
Member

@hollandjg hollandjg commented Jun 28, 2023 •
edited
Loading

  • Add new aliases to the state-dependent-properties:

    • %data.conditions% -> x's
    • %data.observations% -> y's

  • Add deprecation warnings to %observations.dvs% and %observations.ivs%

Prerequisites:

@hollandjg hollandjg linked an issue Jun 28, 2023 that may be closed by this pull request
state-dependent properties of workflow need to be renamed form observations.dvs/ivs to observations.conditions/observations #14
Closed
@hollandjg hollandjg changed the title refactor: rename form observations.dvs/ivs to data.conditions/observations refactor: rename from observations.dvs/ivs to data.conditions/observations Jun 28, 2023
@hollandjg hollandjg self-assigned this Jul 3, 2023
@hollandjg hollandjg marked this pull request as ready for review July 3, 2023 14:29
younesStrittmatter
younesStrittmatter approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

musslick
musslick previously requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@musslick musslick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering: Why "data.observations"
Didn't we determine that everything is data? So why not

"data.observations" -> "observations",
"observations.dvs" -> "dependent_variables"?

@musslick
Copy link
Contributor

musslick commented Jul 3, 2023

I'm wondering: Why "data.observations" Didn't we determine that everything is data? So why not

"data.observations" -> "observations", "observations.dvs" -> "dependent_variables"?

Note that this is just a clarification. Just want to make sure we are fully aligned with the terminology.

@hollandjg
Copy link
Member Author

I'm wondering: Why "data.observations" Didn't we determine that everything is data? So why not
"data.observations" -> "observations", "observations.dvs" -> "dependent_variables"?

Note that this is just a clarification. Just want to make sure we are fully aligned with the terminology.

Good point, though – we should do experiment_data.observations and experiment_data.conditions based on https://docs.google.com/presentation/d/1OdP4M2ByW8GKTFvcCgDG5HDzUwHKdFEhj1ddH4ClvEw/edit#slide=id.g22c9e979475_0_85

@hollandjg hollandjg requested a review from musslick July 5, 2023 14:18
@hollandjg
test: update test results
8419dd4
@hollandjg
refactor: rename data -> experiment_data
2b5ed10
@hollandjg
Merge branch '19-test-update-usages-of-sampler-sample' into 14-state-…
718985d 
…dependent-properties-of-workflow-need-to-be-renamed-form-observationsdvsivs-to-observationsconditionsobservations
@hollandjg hollandjg changed the base branch from main to 19-test-update-usages-of-sampler-sample July 6, 2023 12:34
@benwandrew benwandrew self-requested a review July 6, 2023 14:01
@hollandjg hollandjg changed the base branch from 19-test-update-usages-of-sampler-sample to main July 6, 2023 14:09
benwandrew
benwandrew suggested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a clarifying question and updating some of the deprecation messages.

src/autora/workflow/state/param.py Outdated Show resolved Hide resolved
src/autora/workflow/state/param.py Outdated Show resolved Hide resolved
src/autora/workflow/state/param.py Outdated Show resolved Hide resolved
src/autora/workflow/state/param.py Outdated Show resolved Hide resolved
src/autora/workflow/state/param.py Show resolved Hide resolved
hollandjg and others added 7 commits July 6, 2023 10:41
@hollandjg
Merge branch 'main' into 14-state-dependent-properties-of-workflow-ne…
0669e17 
…ed-to-be-renamed-form-observationsdvsivs-to-observationsconditionsobservations
@hollandjg @benwandrew
Update src/autora/workflow/state/param.py
6ca0d81 
Co-authored-by: benwandrew <[email protected]>
@hollandjg @benwandrew
Update src/autora/workflow/state/param.py
3fee0fa 
Co-authored-by: benwandrew <[email protected]>
@hollandjg @benwandrew
Update src/autora/workflow/state/param.py
b537ec3 
Co-authored-by: benwandrew <[email protected]>
@hollandjg @benwandrew
Update src/autora/workflow/state/param.py
36b4ed7 
Co-authored-by: benwandrew <[email protected]>
@hollandjg
docs: update examples of using state dependent properties
b4e3c9a
@hollandjg
Merge remote-tracking branch 'origin/14-state-dependent-properties-of…
0328e4a 
…-workflow-need-to-be-renamed-form-observationsdvsivs-to-observationsconditionsobservations' into 14-state-dependent-properties-of-workflow-need-to-be-renamed-form-observationsdvsivs-to-observationsconditionsobservations
@hollandjg hollandjg requested a review from benwandrew July 6, 2023 14:46
benwandrew
benwandrew approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hollandjg hollandjg dismissed musslick’s stale review July 6, 2023 20:02

Queries were resolved.

@hollandjg hollandjg added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit 6816a4f Jul 6, 2023
12 checks passed
@hollandjg hollandjg deleted the 14-state-dependent-properties-of-workflow-need-to-be-renamed-form-observationsdvsivs-to-observationsconditionsobservations branch July 6, 2023 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benwandrew benwandrew benwandrew approved these changes

@gtdang gtdang Awaiting requested review from gtdang

@musslick musslick Awaiting requested review from musslick

@younesStrittmatter younesStrittmatter Awaiting requested review from younesStrittmatter

Assignees

@hollandjg hollandjg

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@hollandjg @musslick @benwandrew @younesStrittmatter