Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default state and a more basic introduction #29

Closed
wants to merge 3 commits into from
Closed

feat: add default state and a more basic introduction #29

wants to merge 3 commits into from

Conversation

hollandjg
Copy link
Member

@hollandjg hollandjg commented Jul 11, 2023 •
edited
Loading

TODO:

  • Add model / models support
  • Check datatypes and coercion – use pd.DataFrames
  • Check names against naming convention

@hollandjg hollandjg marked this pull request as ready for review July 11, 2023 15:26
@hollandjg hollandjg marked this pull request as draft July 11, 2023 15:26
younesStrittmatter
younesStrittmatter approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Looks very good.

@hollandjg
Copy link
Member Author

superseded by #32

@hollandjg hollandjg closed this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesStrittmatter younesStrittmatter younesStrittmatter approved these changes

@benwandrew benwandrew Awaiting requested review from benwandrew

@chadcwilliams chadcwilliams Awaiting requested review from chadcwilliams

@gtdang gtdang Awaiting requested review from gtdang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hollandjg @younesStrittmatter