Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue] Write Unit Tests for TrafficRegulator #2366

Open
Chillax-0v0 opened this issue Mar 18, 2025 · 2 comments · May be fixed by #2395
Open

[Good First Issue] Write Unit Tests for TrafficRegulator #2366

Chillax-0v0 opened this issue Mar 18, 2025 · 2 comments · May be fixed by #2395
Assignees
@aiivar
Labels
good first issue Good for newcomers

Comments

@Chillax-0v0
Copy link
Contributor

Chillax-0v0 commented Mar 18, 2025 •
edited
Loading

Problem Description

The com.automq.stream.s3.operator.TrafficRegulator class currently lacks comprehensive unit tests.

Required Changes

  1. Read and understand the original implementation (calculates the next throttling value based on historical input sequences, specifically using an algorithm similar to TCP congestion control algorithms)
  2. Validate that the regulate method works as expected by mocking classes like TrafficMonitor and TrafficRateLimiter
@Chillax-0v0 Chillax-0v0 added the good first issue Good for newcomers label Mar 18, 2025
@aiivar
Copy link

aiivar commented Mar 24, 2025

/assign

@DovahkiinGA
Copy link

/assign

aiivar added a commit to aiivar/automq that referenced this issue Mar 31, 2025
@aiivar
Add unit tests for TrafficRegulator (AutoMQ#2366)
a817984
@aiivar aiivar linked a pull request Mar 31, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiivar aiivar

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(s3stream): Add unit tests for TrafficRegulator (#2366) aiivar/automq
3 participants
@aiivar @Chillax-0v0 @DovahkiinGA