Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): catch storage callback exception #836

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

superhx
Copy link
Contributor

@superhx superhx commented Dec 15, 2023

No description provided.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #836 (12a779b) into main (848cdde) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #836      +/-   ##
============================================
+ Coverage     55.47%   55.53%   +0.05%     
- Complexity     1242     1245       +3     
============================================
  Files           132      132              
  Lines          8530     8530              
  Branches        787      787              
============================================
+ Hits           4732     4737       +5     
+ Misses         3380     3377       -3     
+ Partials        418      416       -2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.69% <ø> (+0.10%) ⬆️
RocketMQ Proxy 37.81% <ø> (+0.10%) ⬆️
RocketMQ Store 74.27% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

@superhx superhx merged commit 1310eda into main Dec 15, 2023
13 of 14 checks passed
@superhx superhx deleted the catch_callback_ex branch December 15, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants